xla icon indicating copy to clipboard operation
xla copied to clipboard

Published 20 hours ago • verified publisher icon pytorch

[c10d] Update c10d.new_group signature.

Open kumpera opened this issue 2 years ago • 3 comments

Fixes upcoming change in https://github.com/pytorch/pytorch/pull/84224

kumpera avatar Sep 26 '22 19:09 kumpera

@kumpera I guess I need to take your PR just as what I did in #3983. It's easier for us to produce the hash you would later need in the pytorch PR. Would you mind? BTW, can we land #73164 first?

alanwaketan avatar Sep 26 '22 20:09 alanwaketan

@kumpera I guess I need to take your PR just as what I did in #3983. It's easier for us to produce the hash you would later need in the pytorch PR. Would you mind? BTW, can we land #73164 first?

Either way works for me, The docs where not clear on how to handle this situation. I'll land https://github.com/pytorch/pytorch/pull/73164 first.

kumpera avatar Sep 26 '22 21:09 kumpera

Yea, it's complicated when it comes to a fork.

alanwaketan avatar Sep 26 '22 21:09 alanwaketan