xla icon indicating copy to clipboard operation
xla copied to clipboard

Published 20 hours ago • verified publisher icon pytorch

TensorFlow June pin update & PyTorch/XLA c++17 migration (follow up)

Open miladm opened this issue 2 years ago • 3 comments

miladm avatar Jul 29 '22 01:07 miladm

@wonjoolee95 this change is breaking test in this CI.

miladm avatar Jul 29 '22 05:07 miladm

@wonjoolee95 this change is breaking test in this CI.

Hmm that PR should actually fix the error shown on the CI, could you try doing a quick rebase on master?

wonjoolee95 avatar Jul 29 '22 05:07 wonjoolee95

Turns out the absence of -Wno-c++11-narrowing breaks pytorch tests and the absence of -Wno-c++14-narrowing breaks the pytorch/xla build. So, I added both flags and this seems to be working!!

CC @JackCaoG @yeounoh

miladm avatar Aug 13 '22 06:08 miladm