Create MatMul op to build MatMul with bias op

Open yeounoh opened this issue 3 years ago • 5 comments

This helps improve matmul with bias computation and partially addresses the performance regression with ViT model. This replaces Dot withCreateMatMul op, which actually calls Dot internally if it's simpler multiplications and calls DotGeneral otherwise.

Jun 19 '22 07:06 yeounoh

failure is unrelated, if you rebase it should go away.

Jun 20 '22 03:06 JackCaoG

ok, nvm. I think it is actually something from the upstram, it should be one of those dynamic shape pr break us. Will check with Nick on Tuesday.

Jun 20 '22 04:06 JackCaoG

@yeounoh Did you verified that with this fix, regression went away?

Jun 23 '22 00:06 JackCaoG

ping, is this pr ready?

Jun 28 '22 04:06 JackCaoG

ping, is this pr ready?

Hey @JackCaoG the PR is not ready. Let me continue the investigation.

Jul 11 '22 19:07 yeounoh

Making the change in PyTorch, https://github.com/pytorch/pytorch/pull/84503 instead. closing this PR without merging.

Sep 02 '22 22:09 yeounoh