vision icon indicating copy to clipboard operation
vision copied to clipboard

Add circular padding

Open SeanScripts opened this issue 1 year ago • 4 comments

Not sure why this wasn't here already, it was already implemented in both pytorch and numpy, just under different names for the padding modes ("circular" and "wrap" respectively). I'm choosing "circular" here since this is for pytorch. Tested and it works fine.

SeanScripts avatar Aug 31 '24 10:08 SeanScripts

:link: Helpful Links

:test_tube: See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/vision/8619

Note: Links to docs will display an error until the docs builds have been completed.

This comment was automatically generated by Dr. CI and updates every 15 minutes.

pytorch-bot[bot] avatar Aug 31 '24 10:08 pytorch-bot[bot]

Hi @SeanScripts!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

facebook-github-bot avatar Aug 31 '24 10:08 facebook-github-bot

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

facebook-github-bot avatar Aug 31 '24 10:08 facebook-github-bot

Thanks for the PR @SeanScripts . Have you found that useful in practice? Note that we aren't adding more features to the traditional torchvision.transforms namespace. New features and enhancements should be going into torchvision.transforms.v2.

NicolasHug avatar Oct 11 '24 12:10 NicolasHug