vision icon indicating copy to clipboard operation
vision copied to clipboard

Fix Missing Labels in FER2013 Dataset #8118

Open NSalberg opened this issue 1 year ago • 2 comments

In the current implementation, labels are not provided for test split.

The FER2013 dataset provides labels for both training and testing in the icml_face_data.csv file.

This pull request reads the data from the icml_face_data.csv instead, providing labels for both the train and test splits.

NSalberg avatar Apr 03 '24 02:04 NSalberg

:link: Helpful Links

:test_tube: See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/vision/8368

Note: Links to docs will display an error until the docs builds have been completed.

:x: 3 New Failures

As of commit e0a702da92c374e1b4c52cbc3b9f73c032c35913 with merge base 5181a854d8b127cf465cd22a67c1b5aaf6ccae05 (image):

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

pytorch-bot[bot] avatar Apr 03 '24 02:04 pytorch-bot[bot]

Hi @NSalberg!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

facebook-github-bot avatar Apr 03 '24 02:04 facebook-github-bot

Thanks for the PR @NSalberg , I followed-up and made the requested changes in https://github.com/pytorch/vision/pull/8452

NicolasHug avatar Jun 04 '24 10:06 NicolasHug