vision icon indicating copy to clipboard operation
vision copied to clipboard

draw_keypoints() float support

Open GsnMithra opened this issue 1 year ago • 1 comments

Follow-up PR: #8150

Hey there!

I've added functionality to the draw_keypoints() method, allowing it to handle both uint8 and float32 image types. I welcome any feedback you may have on these changes.

Thank you!

GsnMithra avatar Feb 17 '24 12:02 GsnMithra

:link: Helpful Links

:test_tube: See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/vision/8276

Note: Links to docs will display an error until the docs builds have been completed.

:x: 3 New Failures, 4 Unrelated Failures

As of commit c9fd6ca77c9e1c30299c19c325c69081385c50fb with merge base c8c3839cb9b0fc52885cafa431460f686c46f5ae (image):

NEW FAILURES - The following jobs have failed:

FLAKY - The following job failed but was likely due to flakiness present on trunk:

BROKEN TRUNK - The following jobs failed but was present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

pytorch-bot[bot] avatar Feb 17 '24 12:02 pytorch-bot[bot]

Hey @NicolasHug,

Thank you for pointing out my mistakes. While it might be second nature for you to find these bugs, I am still in the learning process. I apologize for making you go through my code once again.

Thanks again.

GsnMithra avatar Mar 04 '24 16:03 GsnMithra

No problem at all @GsnMithra thank you for the PR

NicolasHug avatar Mar 04 '24 16:03 NicolasHug