vision icon indicating copy to clipboard operation
vision copied to clipboard

The public v2 utils like `query_size` or `query_chw` are untested

Open NicolasHug opened this issue 2 years ago • 4 comments

If we're going to expose them as public, we need unit tests for them.

NicolasHug avatar Aug 01 '23 09:08 NicolasHug

@NicolasHug can I prod this up in priority? I've started working with v2 transforms and I need these functions to implement custom transforms that I can combine with the builtin ones... I really don't like having imports from _utils, _geometry, etc in my modules.

rwightman avatar Sep 25 '24 18:09 rwightman

Hi @rwightman , just to make sure I understand, you need those to be publicly available from torchvision.transforms.v2?

NicolasHug avatar Sep 30 '24 10:09 NicolasHug

@NicolasHug yes, they're needed to make custom v2 transforms that can handle flat inputs in the _get_params

rwightman avatar Oct 02 '24 16:10 rwightman

OK, sounds good. I exposed anything you might need in https://github.com/pytorch/vision/pull/8670.

Since it's fairly low risk, I'll try to cherry-pick the PR to the release branch so that it's available for you in 0.20 (planned for later this month).

Looking forward to seeing how you use the v2 transforms! LMK if there's anything I can help with.

NicolasHug avatar Oct 03 '24 10:10 NicolasHug