vision
vision copied to clipboard
pytorch
Closing streams to avoid testing issues
Stack from ghstack (oldest at bottom):
- -> #6128
GC workaround is not working inside of test environments as they are keeping references to FH. So we have to close FH manually.
Rebased, would be nice to land to clean torchdata's dependency tests.
If we have reached consensus on everything, I can take over and implement it if you want me to.
@VitalyFedyunin In #6647 I redid this PR with all my suggested changes. We can take the discussion there if you want.
Hi @VitalyFedyunin!
Thank you for your pull request.
We require contributors to sign our Contributor License Agreement, and yours needs attention.
You currently have a record in our system, but the CLA is no longer valid, and will need to be resubmitted.
Process
In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.
Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.
If you have received this in error or have any questions, please contact us at [email protected]. Thanks!
