vision icon indicating copy to clipboard operation
vision copied to clipboard

[DONT MERGE] Dummy PR to check Release/0.13 CI is green

Open YosuaMichael opened this issue 2 years ago • 6 comments

This PR is just to check whether there the CI is green or not for branch release/0.13

YosuaMichael avatar May 25 '22 21:05 YosuaMichael

We already have a PR for that: #5009. Closing this to avoid duplicates.

pmeier avatar May 26 '22 08:05 pmeier

We already have a PR for that: #5009. Closing this to avoid duplicates.

Hi @pmeier , this PR is a bit different from #5009 as it monitor release/0.13 branch instead of main (I will put this on description).

YosuaMichael avatar May 26 '22 08:05 YosuaMichael

Re-opening, because I missed that it uses the release branch as base.

pmeier avatar May 26 '22 08:05 pmeier

@pmeier I think we can be a bit more lenient to allow people create dummy PRs to check the CI, as long as they close it in due time.

datumbox avatar May 26 '22 11:05 datumbox

I agree with the sentiment. If this PR was using main as base, I felt it was justified to close and simultaneously to inform that we already have something like that (no changes and just checking CI). Basically the same what I did on your PR in https://github.com/pytorch/vision/pull/6017#issuecomment-1127284180.

Of course I blundered and base is not main making the other PR irrelevant. The same were true if a test PR introduces any changes.

pmeier avatar May 26 '22 11:05 pmeier

@pmeier I like the proactiveness to keep things clean. We should remain proactive and perhaps eliminate some of the hundreds of stale PRs from years ago.

But for the CI case, I don't think it adds any value closing the PRs like that. While on-call, we often need to indicate to the Release Engineering team that the main branch is broken and provide proof. Redirecting them to a PR with 10+ commits adds unnecessary complexity as they need to confirm that this is indeed a dummy commit on top of main. For all these reasons, I suggest to leave people close their own dummy PRs, provided they haven't left them there forever.

datumbox avatar May 26 '22 12:05 datumbox