translate icon indicating copy to clipboard operation
translate copied to clipboard

beam search

Open Oktai15 opened this issue 5 years ago • 2 comments

According to README:

Currently, we export components (encoder, decoder) to Caffe2 separately and beam search is implemented in C++. In the near future, we will be able to export the beam search as well. We also plan to add export support to more models.

Where can I find this C++ code or exportable (jit) beam search already in repo?

Oktai15 avatar Dec 25 '19 21:12 Oktai15

Sorry README is out-of-date. We already have BeamSearch class fully scripted in ensemble_export.py. Also Pytorch->ONNX->Caffe2 export path as mentioned in README is not supported now. We are switching to TorchScript export so you can call save_to_pytorch() in BeamSearch class to get an exported model.

cndn avatar Dec 27 '19 21:12 cndn

@cndn I see that pytorch-translate has version of BeamSearchV2 that have new improvements, but it doesn't support char source. Why?

Oktai15 avatar Dec 30 '19 15:12 Oktai15