torchx icon indicating copy to clipboard operation
torchx copied to clipboard

feat: add privileged option to local_docker (#897)

Open clumsy opened this issue 1 year ago • 3 comments

Adding privileged option for local_docker so that the container can start in privileged mode, same way we can do this for aws_batch scheduler. Defaults to False, same as in aws_batch.

Test plan: ☑ unit test added ☑ tested locally:

docker inspect --format='{{.HostConfig.Privileged}}' <CONTAINER_ID>
true

clumsy avatar Apr 26 '24 19:04 clumsy

For your consideration, @kiukchung

clumsy avatar Apr 26 '24 19:04 clumsy

Any chance you can check this request, @d4l3k?

clumsy avatar May 06 '24 14:05 clumsy

Any chance you can look at this one, @andywag?

clumsy avatar May 08 '24 19:05 clumsy

Also not sure why it's not giving me an option to run the full tests -- maybe need to bump the PR.

@clumsy sorry for the delay in reviews on this

d4l3k avatar May 29 '24 21:05 d4l3k

No worries, @d4l3k. Should I force push an amended commit to trigger rebuild?

clumsy avatar May 29 '24 21:05 clumsy

Addressed your comment, @d4l3k. Please let me know if further modifications are needed.

clumsy avatar May 30 '24 12:05 clumsy