torchx
torchx copied to clipboard
feat: add privileged option to local_docker (#897)
Adding privileged option for local_docker so that the container can start in privileged mode, same way we can do this for aws_batch scheduler. Defaults to False, same as in aws_batch.
Test plan: ☑ unit test added ☑ tested locally:
docker inspect --format='{{.HostConfig.Privileged}}' <CONTAINER_ID>
true
For your consideration, @kiukchung
Any chance you can check this request, @d4l3k?
Any chance you can look at this one, @andywag?
Also not sure why it's not giving me an option to run the full tests -- maybe need to bump the PR.
@clumsy sorry for the delay in reviews on this
No worries, @d4l3k. Should I force push an amended commit to trigger rebuild?
Addressed your comment, @d4l3k. Please let me know if further modifications are needed.