torchx icon indicating copy to clipboard operation
torchx copied to clipboard

Why can't tracker entrypoint be specified in .torchxconfig

Open clumsy opened this issue 1 year ago • 2 comments

❓ Questions and Help

Please note that this issue tracker is not a help form and this issue will be closed.

Before submitting, please ensure you have gone through our documentation.

Question

The documentation is somewhat confusing and is marked for Advanced use after mentioning the mechanism to reference entrypoint, but is there a reason we can't also specify the tracker's entrypoint right in .torchxconfig in addition to those discoverable via entry_points.txt? E.g.:

[torchx:tracker]
my_tracker=my_module:my_function

[tracker:my_tracker]
...

clumsy avatar Dec 18 '23 21:12 clumsy

If there's no strong reason not to - I can contribute, @kiukchung. Especially since hydra is already in the dependencies we can simply use hydra.utils.get_method/hydra.utils.call

clumsy avatar Dec 18 '23 21:12 clumsy

@clumsy I don't think there is a strong reason, feel free to contribute!

kurman avatar Dec 19 '23 17:12 kurman