torchx icon indicating copy to clipboard operation
torchx copied to clipboard

(torchx/aws_batch) Enable Region Selection in TorchConfig

Open ashvinnihalani opened this issue 3 years ago • 4 comments

QOL improvements for support for AWS regions.

Current Behavior: Use the default Region specified in .aws config

Proposed Behaviour: Have manual override in .torchxconfig. If no override and no default throw and error

Future Improvements: Add profile support. Add fargate support.

ashvinnihalani avatar Dec 20 '22 00:12 ashvinnihalani

Hi @ashvinnihalani!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

facebook-github-bot avatar Dec 20 '22 00:12 facebook-github-bot

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

facebook-github-bot avatar Dec 20 '22 01:12 facebook-github-bot

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

facebook-github-bot avatar Dec 20 '22 01:12 facebook-github-bot

can you make sure the lint, pyre, and python unittests pass?

kiukchung avatar Jan 05 '23 22:01 kiukchung