Add log_path to TorchXRunner
Summary: Currently we have to use a fixed parameter to specify "log_path" (see https://colab.research.google.com/drive/1kOKw5ddweQGmtyADoXfp-xoVdqvRBWV_?usp=sharing#scrollTo=kH0XT8nBJwkC). This way we'll be able to pass it to the TorchXRunner directly, which is more natural. See test plan in notebook.
Differential Revision: D33979622
This pull request was exported from Phabricator. Differential Revision: D33979622
Codecov Report
Merging #382 (656d9b5) into main (4b989d5) will decrease coverage by
0.02%. The diff coverage is66.66%.
@@ Coverage Diff @@
## main #382 +/- ##
==========================================
- Coverage 94.70% 94.67% -0.03%
==========================================
Files 63 63
Lines 3359 3362 +3
==========================================
+ Hits 3181 3183 +2
- Misses 178 179 +1
| Impacted Files | Coverage Δ | |
|---|---|---|
| torchx/runtime/hpo/ax.py | 94.20% <66.66%> (-1.26%) |
:arrow_down: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing dataPowered by Codecov. Last update 4b989d5...656d9b5. Read the comment docs.
Hi @ldworkin!
Thank you for your pull request.
We require contributors to sign our Contributor License Agreement, and yours needs attention.
You currently have a record in our system, but the CLA is no longer valid, and will need to be resubmitted.
Process
In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.
Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.
If you have received this in error or have any questions, please contact us at [email protected]. Thanks!