torchtune icon indicating copy to clipboard operation
torchtune copied to clipboard

[Draft] Add recipe test for llama3

Open SLR722 opened this issue 1 year ago • 2 comments

Context

What is the purpose of this PR? Is it to

  • [ ] add a new feature
  • [ ] fix a bug
  • [x] update tests and/or documentation
  • [ ] other (please add here)

Add llama3 model recipe test and therecipe test design can also generalize to other model types

Changelog

  1. Upload llama3 small checkpoint and llama3 tokenizer to aws
  2. Add recipe tests for llama3 model

Test plan

Please make sure to do each of the following if applicable to your PR. (If you're not sure about any one of these just ask and we will happily help.)

  • [ ] run pre-commit hooks and linters (make sure you've first installed via pre-commit install)
  • [ ] add unit tests for any new functionality
  • [ ] update docstrings for any new or updated methods or classes
  • [ ] run unit tests via pytest tests
  • [ ] run recipe tests via pytest tests -m integration_test
  • [ ] manually run any new or modified recipes with sufficient proof of correctness
    • [ ] include relevant commands and any other artifacts in this summary (pastes of loss curves, eval results, etc.)

SLR722 avatar May 03 '24 07:05 SLR722

:link: Helpful Links

:test_tube: See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/torchtune/929

Note: Links to docs will display an error until the docs builds have been completed.

:white_check_mark: No Failures

As of commit a145748e506c9c8f19ac2d6c0e35d384057bef16 with merge base dc742677d326b4536fb91f465e3d5499f389a2d7 (image): :green_heart: Looks good so far! There are no failures yet. :green_heart:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

pytorch-bot[bot] avatar May 03 '24 07:05 pytorch-bot[bot]

Also let me know what thoughts you have on extending to other recipe tests.

I think with llama3 recipe test as an example, it's easy to expand to other model types (mistral, gemma, phi3 etc) with config, model_type and ckpt_type as params.

It's also worth to add recipe test for lora dpo, but that discussion might be out of the scope of this PR.

SLR722 avatar May 08 '24 06:05 SLR722