torchtune icon indicating copy to clipboard operation
torchtune copied to clipboard

total_training_steps -> global_step

Open tcapelle opened this issue 1 year ago • 1 comments

That's it, renaming the step counter to global_step. Why?

  • It makes more sense and reads better
  • It is named global_step on the HF Trainer, make using torchtune familiar to folks coming from there
  • if we add evals during training (at the end of an epoch for instance) this would make more sense that keeping a "training" naming

tcapelle avatar Apr 30 '24 13:04 tcapelle

:link: Helpful Links

:test_tube: See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/torchtune/903

Note: Links to docs will display an error until the docs builds have been completed.

:white_check_mark: No Failures

As of commit d88522055bb32d173b1e1661af62fc57ee70b4f9 with merge base 437241fda8f23fa822156925a136d88421e2ff86 (image): :green_heart: Looks good so far! There are no failures yet. :green_heart:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

pytorch-bot[bot] avatar Apr 30 '24 13:04 pytorch-bot[bot]