torchtune icon indicating copy to clipboard operation
torchtune copied to clipboard
verified publisher icon pytorch

Delete unused APIs

Open rohan-varma opened this issue 1 year ago • 5 comments

Context

  • All these APIs are unused by our recipes. If they do end up providing value later on, we can always add them back.

Changelog

  • removed get_autocast, get_gradient_scaler, wrap_fsdp and tests for them.

Test plan

  • CI

rohan-varma avatar Apr 19 '24 22:04 rohan-varma

:link: Helpful Links

:test_tube: See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/torchtune/822

Note: Links to docs will display an error until the docs builds have been completed.

:white_check_mark: No Failures

As of commit 58cfd49d92bfb35db9564fef288237ff7f0c40b0 with merge base bec7babec9c924a0ee7ad27e3f6582bc5bd1fef5 (image): :green_heart: Looks good so far! There are no failures yet. :green_heart:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

pytorch-bot[bot] avatar Apr 19 '24 22:04 pytorch-bot[bot]

Very happy to see this PR. CI is red though

ebsmothers avatar Apr 19 '24 23:04 ebsmothers

@rohan-varma what's happening with this PR?

ebsmothers avatar Apr 23 '24 15:04 ebsmothers

Are these in docs?

joecummings avatar Apr 23 '24 23:04 joecummings

@joecummings They aren't in docs. @ebsmothers Thanks for pinging, just updated

rohan-varma avatar Apr 23 '24 23:04 rohan-varma