torchtune icon indicating copy to clipboard operation
torchtune copied to clipboard

update config defaults dataset.packed and log_peak_memory_stats

Open felipemello1 opened this issue 1 year ago • 3 comments

Most configs dont have dataset.packed exposed. We should set it to:

dataset: packed=False # Set to true for great speed ups

Also, we dont log peak memory by default. If it has no impact in TPS, we should set it to True

log_peak_memory_stats=True

also add compile=False to configs that dont have them

felipemello1 avatar Oct 01 '24 19:10 felipemello1

@andrew-pledge-io if it helps... what we often end up having to do is declare the variant and make an additional Connect statement, like:

figma.connect(MyButton, 'https://www.figma.com/design/ABC123', {
  variant: { hasIcon: true }, 
  props: { ...otherProps },
  example: (props) => <MyButton {...props}>My button</MyButton>,
});

figma.connect(MyButton, 'https://www.figma.com/design/ABC123', {
  variant: { hasIcon: false }
  props: { ...otherProps },
  example: (props) => <MyButton hasIcon={false} {...props}>My button</MyButton>,
});

ericandrewscott avatar Sep 16 '24 14:09 ericandrewscott

Hey @andrew-pledge-io @ericandrewscott, you're right that we don't currently offer a way to express this in the React API. I'll discuss how we might solve this this with the team!

tomduncalf-figma avatar Sep 17 '24 09:09 tomduncalf-figma

+1, it's been almost a year

atimofte-mdsol avatar Sep 25 '25 13:09 atimofte-mdsol