torchtune icon indicating copy to clipboard operation
torchtune copied to clipboard

[Feat] Warn users about unused arguments

Open Jackmin801 opened this issue 1 year ago • 0 comments

Why?

The current config parsing code does not provide any error or warning when a user passes an unsupported kwarg to the recipe. This could lead users to believe that a feature is active when it is not either because the recipe didnt support it or because they mispelled the kwarg.

We could parse the kwargs by popping them to keep track of unused kwargs and provide a warning if any passed kwargs went unused.

Result

  • Users will be warned or observe an error when they pass a kwarg that is unsupported to a recipe

Jackmin801 avatar Sep 21 '24 22:09 Jackmin801