torchtitan icon indicating copy to clipboard operation
torchtitan copied to clipboard

profile with modules and stack

Open carmocca opened this issue 10 months ago • 4 comments

I find these two arguments very helpful, maybe others do too.

carmocca avatar Feb 10 '25 18:02 carmocca

with_stack has been caused timeout because it significant slow down the profiling for large models. It's better to make it optional.

fegin avatar Feb 11 '25 18:02 fegin

So do you want that I add a job config argument for with_stack only? Or for both?

carmocca avatar Feb 12 '25 09:02 carmocca

I think it's ok to add a job config. I'll let @fegin comment whether we need two, or one for both, or one for with_stack only.

tianyu-l avatar Feb 12 '25 18:02 tianyu-l

with_stack only.

fegin avatar Feb 13 '25 07:02 fegin