torchtitan icon indicating copy to clipboard operation
torchtitan copied to clipboard

Two trivial fixes

Open jaywonchung opened this issue 1 year ago • 3 comments

I was reading the framework just out of interest and found two quick fixes.

Especially, the rationale behind removing strict=True from zip is:

  1. It's obvious that both iterables have the same length.
  2. strict=True was introduced in zip in Python 3.10, but pyproject.toml specifies requires-python >= 3.8.

jaywonchung avatar Oct 12 '24 03:10 jaywonchung

Hi @jaywonchung!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

facebook-github-bot avatar Oct 12 '24 03:10 facebook-github-bot

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

facebook-github-bot avatar Oct 12 '24 03:10 facebook-github-bot

re 2: seems https://github.com/pytorch/torchtitan/issues/62 was closed too early? cc: @tianyu-l we can just get rid of the strict=True though -- I agree it is not too necessary

awgu avatar Oct 12 '24 14:10 awgu