torchrec icon indicating copy to clipboard operation
torchrec copied to clipboard

Published 20 hours ago • verified publisher icon pytorch

Simplify custom op naming for meta functionalization of sparse modules

Open PaulZhang12 opened this issue 9 months ago • 2 comments

Summary: Registering custom ops for meta functionalization with ids can lead to hash collisions, resulting in wrong dimensions for a sparse module. This diff replaces custom op naming to just the dimension that is returned, alongside the module type, to ensure that the right dimensions are always returned and simplify the custom op naming logic significantly.

Differential Revision: D57108438

PaulZhang12 avatar May 09 '24 19:05 PaulZhang12

This pull request was exported from Phabricator. Differential Revision: D57108438

facebook-github-bot avatar May 09 '24 19:05 facebook-github-bot

This pull request was exported from Phabricator. Differential Revision: D57108438

facebook-github-bot avatar May 10 '24 02:05 facebook-github-bot