torchdistx icon indicating copy to clipboard operation
torchdistx copied to clipboard

Support PyTorch 2.1.0

Open Seventeen17 opened this issue 1 year ago • 6 comments

What does this PR do:

Fixing compatibility issues with PyTorch versions above 2.1.0, corresponding issue: #79

Does your PR introduce any breaking changes? If yes, please list them: ProxyVariableHooks::basic_autograd_not_implemented_fallback

Seventeen17 avatar Nov 01 '23 06:11 Seventeen17

Hi @Seventeen17!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

facebook-github-bot avatar Nov 01 '23 06:11 facebook-github-bot

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

facebook-github-bot avatar Nov 01 '23 08:11 facebook-github-bot

@H-Huang Could you please help me check what's wrong with runners?

Seventeen17 avatar Nov 06 '23 06:11 Seventeen17

Hi @Seventeen17 thank you for adding this PR. I managed to install the torchdistx with your PR. However, I failed to initialize the 65B model with FSDP. Did you manage to initialize a large model? Thanks in advance for your kindness.

gouchangjiang avatar Dec 18 '23 08:12 gouchangjiang

@Seventeen17 I managed to train the large model. Thanks again for your contribution.

gouchangjiang avatar Dec 18 '23 12:12 gouchangjiang

Hi @Seventeen17 thank you for adding this PR. I managed to install the torchdistx with your PR. However, I failed to initialize the 65B model with FSDP. Did you manage to initialize a large model? Thanks in advance for your kindness.

I applied this fix to successfully initialize and train 65B model in PyTorch/XLA FSDP, but it also need some fix in PyTorch/XLA FSDP.

Seventeen17 avatar Jan 03 '24 07:01 Seventeen17