tnt icon indicating copy to clipboard operation
tnt copied to clipboard

[draft] stateful dataloader and sampler

Open edward-io opened this issue 2 years ago • 2 comments

Please read through our contribution guide prior to creating your pull request.

Summary:

Test plan:

Fixes #{issue number}

edward-io avatar Sep 15 '22 03:09 edward-io

Codecov Report

Merging #190 (8b3e66e) into master (0feb0c1) will increase coverage by 0.32%. The diff coverage is 93.86%.

:exclamation: Current head 8b3e66e differs from pull request most recent head 3dd469a. Consider uploading reports for the commit 3dd469a to get more accurate results

@@            Coverage Diff             @@
##           master     #190      +/-   ##
==========================================
+ Coverage   86.46%   86.79%   +0.32%     
==========================================
  Files          61       64       +3     
  Lines        3391     3543     +152     
==========================================
+ Hits         2932     3075     +143     
- Misses        459      468       +9     
Impacted Files Coverage Δ
torchtnt/utils/distributed.py 69.03% <25.00%> (-2.59%) :arrow_down:
torchtnt/data/samplers.py 90.47% <90.47%> (ø)
tests/data/conftest.py 100.00% <100.00%> (ø)
tests/data/test_multi_dataloader.py 99.48% <100.00%> (ø)
tests/data/test_stateful_dataloader.py 100.00% <100.00%> (ø)
torchtnt/data/__init__.py 100.00% <100.00%> (ø)
torchtnt/data/dataloaders.py 100.00% <100.00%> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

codecov[bot] avatar Sep 15 '22 03:09 codecov[bot]

@edward-io has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot avatar Sep 15 '22 03:09 facebook-github-bot

Hi @edward-io!

Thank you for your pull request.

We require contributors to sign our Contributor License Agreement, and yours needs attention.

You currently have a record in our system, but the CLA is no longer valid, and will need to be resubmitted.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

facebook-github-bot avatar Nov 09 '22 23:11 facebook-github-bot