text icon indicating copy to clipboard operation
text copied to clipboard

Add TorchData as a required dependency in TorchText for 0.12.0 release

Open Nayef211 opened this issue 3 years ago • 1 comments

🚀 Feature

TorchData is currently an optional dependency which means users have to pip install torchdata if they want to be able to use our datasets. Since datasets are a core feature of TorchText, we want to improve the user experience by making TorchData a required dependency.

After the next torch and torchdata branch cuts for version 1.12, we want to take a hard dependency on the torchdata nightlies.

Nayef211 avatar May 05 '22 20:05 Nayef211

cc @atalman @malfet @parmeet @ejguan @seemethere

Nayef211 avatar May 05 '22 20:05 Nayef211

@atalman @malfet @seemethere @ejguan do you guys know if we have the go ahead to make TorchData as a required dep moving forward? I know we were aiming to do this with the last release but it got pushed back to the 0.13 release instead.

Nayef211 avatar Sep 26 '22 17:09 Nayef211

Yeah, it would be great if we TorchData are aware of the requirements/criteria to make this happen. Then, we can investigate if we have any step missing.

ejguan avatar Sep 26 '22 18:09 ejguan

After #1979 is fixed, could we start to make torchdata as a hard dependency in the main branch? Then, we will be able to spend time on figuring out what's wrong with the installation script.

ejguan avatar Nov 04 '22 13:11 ejguan

Closed by #1985

Nayef211 avatar Nov 21 '22 16:11 Nayef211