text icon indicating copy to clipboard operation
text copied to clipboard

Revamp Pytorch Benchmark implementations for pytorch_struct and Attention is All You Need models

Open abhinavarora opened this issue 4 years ago • 5 comments

🚀 Feature

Revamp Pytorch Benchmark implementations for pytorch_struct and Attention is All You Need models

Motivation Since we deprecated pytorch.legacy, we need to revamp these tutorials to make them adhere to newer TorchText APIs.

abhinavarora avatar Nov 12 '21 21:11 abhinavarora

Where can these be found? I'd be happy to take a stab at this.

erip avatar Dec 22 '21 12:12 erip

This?

https://github.com/pytorch/benchmark/blob/121ea0230d9f675928625b9a9c83d4cd9772f27f/torchbenchmark/models/pytorch_struct/init.py

https://github.com/pytorch/benchmark/tree/121ea0230d9f675928625b9a9c83d4cd9772f27f/torchbenchmark/models/attention_is_all_you_need_pytorch

mthrok avatar Dec 22 '21 13:12 mthrok

Just started this. Tracking here.

  • [ ] pytorch_struct
  • [ ] aiayn

erip avatar Dec 25 '21 12:12 erip

I think the pytorch_struct refactor is ready for review: https://github.com/pytorch/benchmark/pull/673 cc @mthrok @abhinavarora

erip avatar Dec 27 '21 22:12 erip

Due to a recent code change in torchtext(https://github.com/pytorch/text/pull/1654), another workaround is added: https://github.com/pytorch/benchmark/pull/795

xuzhao9 avatar Mar 14 '22 20:03 xuzhao9