text icon indicating copy to clipboard operation
text copied to clipboard

const string for c10::string_view

Open cpuhrsch opened this issue 5 years ago • 0 comments

This PR typedefs strings that are meant to be constant, i.e. read-only. They can then be optionally replaced by std::string_view.

Also adds the ever so important "#pragma once" to the header files.

This will also need to change the key type of the Vocab hash table, since the string passed to find is now just a string_view, which doesn't match the type.

cpuhrsch avatar Sep 22 '20 01:09 cpuhrsch