test-infra icon indicating copy to clipboard operation
test-infra copied to clipboard

[codev] Move PyTorch-specific logic from github-export-checks into a different check

Open huydhn opened this issue 1 year ago • 3 comments

Atm, github-export-checks both checks if a diff has been exported and can be merged, the generic part that applies to all repos, and also run specific checks for PyTorch (have reviewer, CLA, green PR signals). This is a common source of confusion leading to the abuse using of the bypass flag. For example, github-export-checks will always be red when a diff is first created.

Aiming for a better UX here, let's take the PyTorch-specific logic of github-export-checks and move it to a different check that we can maintain:

  • The generic part for checking if a diff with OSS content has been exported and can be merged should remain the same
  • There is a new check for checking the PyTorch PR status including reviewer, CLA, and PR signals. This part comes from trymerge

cc @PaliC @clee2000 @kit1980

Update from @PaliC is that works can be done to split this into the a generic part and a PyTorch-specific part.

huydhn avatar Dec 14 '23 20:12 huydhn

Looking at D51738439, it looks like @PaliC is already on this

huydhn avatar Dec 14 '23 21:12 huydhn

@izaitsevfb raises a potential blocker where only github-export-checks has special security permissions to access the internet, i.e. calling GitHub

huydhn avatar Dec 14 '23 22:12 huydhn

@huydhn Chatting with Jon, this does not seem to be a blocker (afaict), we should be able to just create the second job

PaliC avatar Dec 15 '23 19:12 PaliC