test-infra icon indicating copy to clipboard operation
test-infra copied to clipboard

[dr ci] executorch docs preview link says "Python docs" when it's really all docs

Open dbort opened this issue 1 year ago • 1 comments

On excutorch PRs (e.g., https://github.com/pytorch/executorch/pull/1106), the pytorch-bot "Helpful Links" section points to the generated docs with the message "Preview Python docs built from this PR". But for executorch, those aren't just python docs, they're all of the docs for an independent website (which also contains language-agnostic docs and C++ docs)

image

@svekars tracked the message to: https://github.com/pytorch/test-infra/blob/54ee5e79bd91e5a4591ec3c9be91f10bce04bc9b/torchci/lib/drciUtils.ts#L57

It would be nice if this class of comment on executorch PRs didn't mention the "Python" part.

dbort avatar Oct 30 '23 17:10 dbort

Part of the issue may be that executorch isn't a "domain library", but a new class of standalone repo.

dbort avatar Oct 30 '23 17:10 dbort