serve icon indicating copy to clipboard operation
serve copied to clipboard

Follow up on token authentication PR comments

Open mreso opened this issue 1 year ago • 5 comments

🚀 The feature

Follow up on refactor comments in https://github.com/pytorch/serve/pull/3163

Motivation, pitch

Follow up on refactor comments in https://github.com/pytorch/serve/pull/3163

Alternatives

No response

Additional context

No response

mreso avatar Jun 07 '24 23:06 mreso

We also need to go through all examples and add the right options.

mreso avatar Jun 13 '24 17:06 mreso

Benchmark tool is also affected.

mreso avatar Jun 13 '24 17:06 mreso

This needs to be described in api docs as well.

mreso avatar Jun 13 '24 17:06 mreso

Benchmark tool is also affected.

Benchmark tool should be fixed in this PR https://github.com/pytorch/serve/pull/3188

udaij12 avatar Jun 13 '24 19:06 udaij12

Doc changes in this PR #3183

udaij12 avatar Jun 14 '24 18:06 udaij12

Think we have address all token related PRs. Closing this issue.

udaij12 avatar Jul 09 '24 21:07 udaij12