serve icon indicating copy to clipboard operation
serve copied to clipboard

[WIP] Speedup unit and regression tests

Open mreso opened this issue 2 years ago • 1 comments

Description

Please read our CONTRIBUTING.md prior to creating your first pull request.

Please include a summary of the feature or issue being fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes #(issue)

Type of change

Please delete options that are not relevant.

  • [ ] Bug fix (non-breaking change which fixes an issue)
  • [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • [ ] New feature (non-breaking change which adds functionality)
  • [ ] This change requires a documentation update

Feature/Issue validation/testing

Please describe the Unit or Integration tests that you ran to verify your changes and relevant result summary. Provide instructions so it can be reproduced. Please also list any relevant details for your test configuration.

  • [ ] Test A Logs for Test A

  • [ ] Test B Logs for Test B

Checklist:

  • [ ] Did you have fun?
  • [ ] Have you added tests that prove your fix is effective or that this feature works?
  • [ ] Has code been commented, particularly in hard-to-understand areas?
  • [ ] Have you made corresponding changes to the documentation?

mreso avatar Mar 24 '23 00:03 mreso

Codecov Report

Merging #2198 (4ab84c8) into master (c164374) will increase coverage by 0.25%. The diff coverage is 100.00%.

:exclamation: Current head 4ab84c8 differs from pull request most recent head ce0219f. Consider uploading reports for the commit ce0219f to get more accurate results

@@            Coverage Diff             @@
##           master    #2198      +/-   ##
==========================================
+ Coverage   71.45%   71.70%   +0.25%     
==========================================
  Files          73       73              
  Lines        3296     3297       +1     
  Branches       57       57              
==========================================
+ Hits         2355     2364       +9     
+ Misses        941      930      -11     
- Partials        0        3       +3     
Impacted Files Coverage Δ
...l-archiver/model_archiver/model_packaging_utils.py 60.13% <100.00%> (+5.52%) :arrow_up:

... and 1 file with indirect coverage changes

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

codecov[bot] avatar Mar 24 '23 21:03 codecov[bot]

Closing this draft as the main contributions are already in main after merging https://github.com/pytorch/serve/pull/2984.

mreso avatar Mar 01 '24 18:03 mreso