serve icon indicating copy to clipboard operation
serve copied to clipboard

fix: model status API for kserve

Open jagadeeshi2i opened this issue 3 years ago • 2 comments

Signed-off-by: jagadeesh [email protected]

Description

fixes: kserve/kserve-1915

Issue: kserve model status API returns ready status only after a predict request as model is not loaded in startup. Soln: Loads all TS models at start with load_models property and kserve load model method.

Gif of model status working after TS isvc deployment. output model-status.log

Type of change

Please delete options that are not relevant.

  • [x] Bug fix (non-breaking change which fixes an issue)
  • [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • [ ] New feature (non-breaking change which adds functionality)
  • [ ] This change requires a documentation update

Feature/Issue validation/testing

Please describe the Unit or Integration tests that you ran to verify your changes and relevant result summary. Provide instructions so it can be reproduced. Please also list any relevant details for your test configuration.

  • [ ] Test A Logs for Test A

  • [ ] Test B Logs for Test B

Checklist:

  • [ ] Did you have fun?
  • [ ] Have you added tests that prove your fix is effective or that this feature works?
  • [ ] Has code been commented, particularly in hard-to-understand areas?
  • [ ] Have you made corresponding changes to the documentation?

jagadeeshi2i avatar Jul 28 '22 04:07 jagadeeshi2i

Codecov Report

Merging #1773 (139f65b) into master (7fef9d2) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1773   +/-   ##
=======================================
  Coverage   45.19%   45.19%           
=======================================
  Files          64       64           
  Lines        2604     2604           
  Branches       60       60           
=======================================
  Hits         1177     1177           
  Misses       1427     1427           

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

codecov[bot] avatar Jul 28 '22 04:07 codecov[bot]

@jagadeeshi2i Windows CI is known to flake so CI is all green Screen Shot 2022-08-08 at 9 29 24 AM

msaroufim avatar Aug 08 '22 16:08 msaroufim