rl icon indicating copy to clipboard operation
rl copied to clipboard

[Feature] SAC compatibility with composite distributions.

Open albertbou92 opened this issue 1 year ago • 1 comments

Description

This PR adapts the SAC objective to be compatible with composite distributions.

DiscreteSAC seems a little bit more tricky, as it requires computing the log probabilities of all possible actions. In the case of composite distributions this might mean the probabilities of all combinations of actions.

Motivation and Context

Why is this change required? What problem does it solve? If it fixes an open issue, please link to the issue here. You can use the syntax close #15213 if this solves the issue #15213

  • [ ] I have raised an issue to propose this change (required for new features and bug fixes)

Types of changes

What types of changes does your code introduce? Remove all that do not apply:

  • [ ] Bug fix (non-breaking change which fixes an issue)
  • [x] New feature (non-breaking change which adds core functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to change)
  • [ ] Documentation (update in the documentation)
  • [ ] Example (update in the folder of examples)

Checklist

Go over all the following points, and put an x in all the boxes that apply. If you are unsure about any of these, don't hesitate to ask. We are here to help!

  • [ ] I have read the CONTRIBUTION guide (required)
  • [ ] My change requires a change to the documentation.
  • [ ] I have updated the tests accordingly (required for a bug fix or a new feature).
  • [ ] I have updated the documentation accordingly.

albertbou92 avatar Sep 22 '24 22:09 albertbou92

:link: Helpful Links

:test_tube: See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/rl/2447

Note: Links to docs will display an error until the docs builds have been completed.

:x: 12 New Failures, 7 Unrelated Failures

As of commit 53ba3715279dc684cf58276ee7568c9ba42c70c7 with merge base f411f932e1ceec4c3ab524e84836a9f660e7865b (image):

NEW FAILURES - The following jobs have failed:

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

pytorch-bot[bot] avatar Sep 22 '24 22:09 pytorch-bot[bot]