rl icon indicating copy to clipboard operation
rl copied to clipboard
verified publisher icon pytorch

[BUG] sota-implementation requires nightly built

Open jimdor opened this issue 1 year ago • 2 comments

Describe the bug

dqn_cartpole from sota-implementations/dqn doesn't working. Crashes with: ImportError: cannot import name 'Composite' from 'torchrl.data'

To Reproduce

Just run dqn_cartpole.py, it will call ulits_cartpole.py and then it will crash with ImportError

System info

Describe the characteristic of your environment:

  • The library was installed using pip
  • Python version = 3.9.19

Reason and Possible fixes

After some time i think rename Composite -> CompositeSpec in importing and in it's only one will fix this issue

Checklist

  • [x] I have checked that there is no similar issue in the repo (required)
  • [x] I have read the documentation (required)
  • [x] I have provided a minimal working example to reproduce the bug (required)

jimdor avatar Aug 26 '24 08:08 jimdor

This is due to a change in the specs names, try from v0.4.0

https://github.com/pytorch/rl/tree/v0.4.0

vmoens avatar Aug 26 '24 13:08 vmoens