rl icon indicating copy to clipboard operation
rl copied to clipboard

[Feature] Checking for dtype to all tensorspec is_in funcs

Open namanxkumar opened this issue 1 year ago • 2 comments

Description

I've added a check to all is_in functions in TensorSpec for the datatype, as specified in #793.

Motivation and Context

Why is this change required? What problem does it solve? If it fixes an open issue, please link to the issue here. You can use the syntax close #15213 if this solves the issue #15213

Close #793 initially proposed in #783

  • [ ] I have raised an issue to propose this change (required for new features and bug fixes)

Types of changes

What types of changes does your code introduce? Remove all that do not apply:

  • [x] Bug fix (non-breaking change which fixes an issue)
  • [ ] New feature (non-breaking change which adds core functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to change)
  • [ ] Documentation (update in the documentation)
  • [ ] Example (update in the folder of examples)

Checklist

Go over all the following points, and put an x in all the boxes that apply. If you are unsure about any of these, don't hesitate to ask. We are here to help!

  • [x] I have read the CONTRIBUTION guide (required)
  • [ ] My change requires a change to the documentation.
  • [ ] I have updated the tests accordingly (required for a bug fix or a new feature).
  • [ ] I have updated the documentation accordingly.

namanxkumar avatar Feb 22 '24 13:02 namanxkumar

:link: Helpful Links

:test_tube: See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/rl/1952

Note: Links to docs will display an error until the docs builds have been completed.

:x: 23 New Failures

As of commit b1352fbaad549ec933217f96d9533589235d0ed5 with merge base 23bf3151a5bb1377d6ba65c5edb5659618af0da3 (image):

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

pytorch-bot[bot] avatar Feb 22 '24 13:02 pytorch-bot[bot]

I've fixed the reviewed changes, and added checks for shape where applicable.

namanxkumar avatar Feb 28 '24 15:02 namanxkumar