pytorch icon indicating copy to clipboard operation
pytorch copied to clipboard

[ONNX] Clean up patch functions

Open justinchuby opened this issue 1 year ago • 1 comments

Stack from ghstack (oldest at bottom):

  • -> #83136

Changes:

  • Move namespace handling from _new_node to _graph_op for clarity
  • Always require the aten namespace when creating aten ops. Remove the aten argument supplied in _aten_op for clarity
  • Rename the _ATTR_PATTERN global
  • Improve types
  • Update _add_attribute to raise ValueErrors

justinchuby avatar Aug 10 '22 01:08 justinchuby

:link: Helpful links

:white_check_mark: No Failures (4 Pending)

As of commit a3ed7b90ab (more details on the Dr. CI page):

Expand to see more

:green_heart: :green_heart: Looks good so far! There are no failures yet. :green_heart: :green_heart:


This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

facebook-github-bot avatar Aug 10 '22 01:08 facebook-github-bot

@pytorchbot rebase

justinchuby avatar Aug 23 '22 01:08 justinchuby

@pytorchbot successfully started a rebase job. Check the current status here

pytorchmergebot avatar Aug 23 '22 01:08 pytorchmergebot

Successfully rebased gh/justinchuby/5/orig onto refs/remotes/origin/master, please pull locally before adding more changes (for example, via ghstack checkout https://github.com/pytorch/pytorch/pull/83136)

pytorchmergebot avatar Aug 23 '22 01:08 pytorchmergebot

cc @BowenBao

justinchuby avatar Aug 23 '22 01:08 justinchuby

@pytorchbot rebase

justinchuby avatar Aug 25 '22 20:08 justinchuby

@pytorchbot successfully started a rebase job. Check the current status here

pytorchmergebot avatar Aug 25 '22 20:08 pytorchmergebot

Successfully rebased gh/justinchuby/5/orig onto refs/remotes/origin/master, please pull locally before adding more changes (for example, via ghstack checkout https://github.com/pytorch/pytorch/pull/83136)

pytorchmergebot avatar Aug 25 '22 20:08 pytorchmergebot

@pytorchbot merge -g

justinchuby avatar Aug 26 '22 19:08 justinchuby

@pytorchbot successfully started a merge job. Check the current status here. The merge job was triggered with the green (-g) flag. This means that your change will be merged once all checks on your PR have passed (ETA: 0-4 Hours). If this is not the intended behavior, feel free to use some of the other merge options in the wiki. Please reach out to the PyTorch DevX Team with feedback or questions!

pytorchmergebot avatar Aug 26 '22 19:08 pytorchmergebot