pytorch
pytorch copied to clipboard
[ONNX] Clean up patch functions
Stack from ghstack (oldest at bottom):
- -> #83136
Changes:
- Move namespace handling from
_new_node
to_graph_op
for clarity - Always require the
aten
namespace when creating aten ops. Remove theaten
argument supplied in_aten_op
for clarity - Rename the
_ATTR_PATTERN
global - Improve types
- Update
_add_attribute
to raise ValueErrors
:link: Helpful links
- :test_tube: See artifacts and rendered test results at hud.pytorch.org/pr/83136
- :heavy_multiplication_x: Python docs build was skipped
- :heavy_multiplication_x: C++ docs build was skipped
- :question:Need help or want to give feedback on the CI? Visit our office hours
:white_check_mark: No Failures (4 Pending)
As of commit a3ed7b90ab (more details on the Dr. CI page):
Expand to see more
:green_heart: :green_heart: Looks good so far! There are no failures yet. :green_heart: :green_heart:
This comment was automatically generated by Dr. CI (expand for details).
Please report bugs/suggestions to the (internal) Dr. CI Users group.
@pytorchbot rebase
@pytorchbot successfully started a rebase job. Check the current status here
Successfully rebased gh/justinchuby/5/orig
onto refs/remotes/origin/master
, please pull locally before adding more changes (for example, via ghstack checkout https://github.com/pytorch/pytorch/pull/83136
)
cc @BowenBao
@pytorchbot rebase
@pytorchbot successfully started a rebase job. Check the current status here
Successfully rebased gh/justinchuby/5/orig
onto refs/remotes/origin/master
, please pull locally before adding more changes (for example, via ghstack checkout https://github.com/pytorch/pytorch/pull/83136
)
@pytorchbot merge -g
@pytorchbot successfully started a merge job. Check the current status here. The merge job was triggered with the green (-g) flag. This means that your change will be merged once all checks on your PR have passed (ETA: 0-4 Hours). If this is not the intended behavior, feel free to use some of the other merge options in the wiki. Please reach out to the PyTorch DevX Team with feedback or questions!