pytorch icon indicating copy to clipboard operation
pytorch copied to clipboard

[Profiler] Start moving python bindings out of autograd

Open robieta opened this issue 1 year ago • 1 comments

Stack from ghstack (oldest at bottom):

  • #83033
  • #82993
  • #82992
  • -> #82584

A lot of profiler code still lives in autograd for historic reasons. However as we formalize and clean up profiler internals it makes sense to pull more and more into the profiler folders/namespace. For now I'm just moving some of the core config data structures and those related to torch::profiler::impl::Result to keep the scope manageable.

Differential Revision: D37961462

NOTE FOR REVIEWERS: This PR has internal Facebook specific changes or comments, please review them on Phabricator!

robieta avatar Aug 01 '22 17:08 robieta

:link: Helpful links

:white_check_mark: No Failures (0 Pending)

As of commit 7007f78dbf (more details on the Dr. CI page):

Expand to see more

:green_heart: :green_heart: Looks good so far! There are no failures yet. :green_heart: :green_heart:


This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

facebook-github-bot avatar Aug 01 '22 17:08 facebook-github-bot

@pytorchbot merge -g

robieta avatar Aug 19 '22 17:08 robieta

@pytorchbot successfully started a merge job. Check the current status here. The merge job was triggered with the green (-g) flag. This means that your change will be merged once all checks on your PR have passed (ETA: 0-4 Hours). If this is not the intended behavior, feel free to use some of the other merge options in the wiki. Please reach out to the PyTorch DevX Team with feedback or questions!

pytorchmergebot avatar Aug 19 '22 17:08 pytorchmergebot

Hey @robieta. You've committed this PR, but it does not have both a 'release notes: ...' and 'topics: ...' label. Please add one of each to the PR. The 'release notes: ...' label should represent the part of PyTorch that this PR changes (fx, autograd, distributed, etc) and the 'topics: ...' label should represent the kind of PR it is (not user facing, new feature, bug fix, perf improvement, etc). The list of valid labels can be found here for the 'release notes: ...' and here for the 'topics: ...'. For changes that are 'topic: not user facing' there is no need for a release notes label.

github-actions[bot] avatar Aug 19 '22 17:08 github-actions[bot]