pytorch icon indicating copy to clipboard operation
pytorch copied to clipboard

[primTorch] added ref for nn.functional.glu

Open fdrocha opened this issue 1 year ago • 1 comments

Stack from ghstack (oldest at bottom):

  • #82819
  • -> #82214
  • #82817

fdrocha avatar Jul 26 '22 10:07 fdrocha

:link: Helpful links

:white_check_mark: No Failures (1 Pending)

As of commit 8e4952ad2f (more details on the Dr. CI page):

Expand to see more

:green_heart: :green_heart: Looks good so far! There are no failures yet. :green_heart: :green_heart:


This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

facebook-github-bot avatar Jul 26 '22 10:07 facebook-github-bot

Ok, now I think it really is ready. I added the type promotion logic to the cuda kernel. While doing it I noticed that sinc kernel was also missing it so I added it there too. @ngimel and @Lezcano could you PTAL?

fdrocha avatar Aug 17 '22 15:08 fdrocha

@pytorchbot merge -g

fdrocha avatar Aug 17 '22 16:08 fdrocha

@pytorchbot successfully started a merge job. Check the current status here. The merge job was triggered with the green (-g) flag. This means that your change will be merged once all checks on your PR have passed (ETA: 0-4 Hours). If this is not the intended behavior, feel free to use some of the other merge options in the wiki. Please reach out to the PyTorch DevX Team with feedback or questions!

pytorchmergebot avatar Aug 17 '22 16:08 pytorchmergebot