pytorch icon indicating copy to clipboard operation
pytorch copied to clipboard

[Pipelining] Add to/from CSV format and improved __repr__

Open wconstab opened this issue 1 year ago • 17 comments

Stack from ghstack (oldest at bottom):

  • #129810
  • #129786
  • -> #129264

_Action.repr gets rearranged so it doesn't require an underscore or a 's' prefix, but still keeps multi-digit stage and microbatch indices separated by an alpha character indicating the action type.

to/from CSV methods allow dumping a generated schedule to CSV format for offline visualization or manual editing in a spreadsheet and reloading to use at runtime.

cc @mrshenli @pritamdamania87 @zhaojuanmao @satgera @gqchen @aazzolini @osalpekar @jiayisuse @H-Huang @kwen2501 @awgu @penguinwu @fegin @XilunWu @wanchaol @fduwjj @wz337 @tianyu-l @yf225 @chauhang @d4l3k

wconstab avatar Jun 21 '24 19:06 wconstab

:link: Helpful Links

:test_tube: See artifacts and rendered test results at hud.pytorch.org/pr/129264

Note: Links to docs will display an error until the docs builds have been completed.

:heavy_exclamation_mark: 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

:x: 3 New Failures

As of commit 3a951ea81bac469c2ac76b99ea91120476ff71c6 with merge base 9ae78a578caff195821ad535a9e8d8ef59552142 (image):

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

pytorch-bot[bot] avatar Jun 21 '24 19:06 pytorch-bot[bot]

@pytorchbot merge

H-Huang avatar Jun 28 '24 17:06 H-Huang

Merge failed

Reason: This PR needs a release notes: label If your changes are user facing and intended to be a part of release notes, please use a label starting with release notes:.

If not, please add the topic: not user facing label.

To add a label, you can comment to pytorchbot, for example @pytorchbot label "topic: not user facing"

For more information, see https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

Details for Dev Infra team Raised by workflow job

pytorchmergebot avatar Jun 28 '24 17:06 pytorchmergebot

@pytorchbot merge

wconstab avatar Jun 28 '24 18:06 wconstab

image ok, this needs to be fixed. Ill put a merge cmd on the PR right before this and then work on trying to fix this PR docs

wconstab avatar Jun 28 '24 18:06 wconstab

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging Check the merge workflow status here

pytorchmergebot avatar Jun 28 '24 18:06 pytorchmergebot

Merge failed

Reason: 1 mandatory check(s) failed. The first few are:

Dig deeper by viewing the failures on hud

Details for Dev Infra team Raised by workflow job

Failing merge rule: Core Maintainers

pytorchmergebot avatar Jun 28 '24 18:06 pytorchmergebot

@pytorchbot merge

wconstab avatar Jun 28 '24 21:06 wconstab

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging Check the merge workflow status here

pytorchmergebot avatar Jun 28 '24 21:06 pytorchmergebot

The merge job was canceled or timed out. This most often happen if two merge requests were issued for the same PR, or if merge job was waiting for more than 6 hours for tests to finish. In later case, please do not hesitate to reissue the merge command For more information see pytorch-bot wiki.

pytorchmergebot avatar Jun 29 '24 01:06 pytorchmergebot

@pytorchhbot merge

wconstab avatar Jun 29 '24 01:06 wconstab

@pytorchbot merge

wconstab avatar Jun 29 '24 01:06 wconstab

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging Check the merge workflow status here

pytorchmergebot avatar Jun 29 '24 01:06 pytorchmergebot

The merge job was canceled or timed out. This most often happen if two merge requests were issued for the same PR, or if merge job was waiting for more than 6 hours for tests to finish. In later case, please do not hesitate to reissue the merge command For more information see pytorch-bot wiki.

pytorchmergebot avatar Jun 29 '24 07:06 pytorchmergebot

@pytorchbot merge

H-Huang avatar Jun 29 '24 13:06 H-Huang

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging Check the merge workflow status here

pytorchmergebot avatar Jun 29 '24 13:06 pytorchmergebot

The merge job was canceled or timed out. This most often happen if two merge requests were issued for the same PR, or if merge job was waiting for more than 6 hours for tests to finish. In later case, please do not hesitate to reissue the merge command For more information see pytorch-bot wiki.

pytorchmergebot avatar Jun 29 '24 19:06 pytorchmergebot

@pytorchbot merge

H-Huang avatar Jul 01 '24 15:07 H-Huang

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging Check the merge workflow status here

pytorchmergebot avatar Jul 01 '24 15:07 pytorchmergebot

Merge failed

Reason: 1 jobs have failed, first few of them are: linux-binary-libtorch-pre-cxx11 / libtorch-cpu-shared-with-deps-pre-cxx11-build / build

Details for Dev Infra team Raised by workflow job

pytorchmergebot avatar Jul 01 '24 15:07 pytorchmergebot

@pytorchbot merge -i

H-Huang avatar Jul 01 '24 21:07 H-Huang

Merge started

Your change will be merged while ignoring the following 5 checks: linux-binary-libtorch-pre-cxx11 / libtorch-cpu-shared-with-deps-pre-cxx11-build / build, trunk / win-vs2019-cuda11.8-py3 / build, trunk / win-vs2019-cpu-py3 / build, trunk / macos-py3-arm64-mps / test (mps, 1, 1, macos-m1-13), trunk / macos-py3-arm64-mps / test (mps, 1, 1, macos-m1-14)

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging Check the merge workflow status here

pytorchmergebot avatar Jul 01 '24 21:07 pytorchmergebot