pytorch icon indicating copy to clipboard operation
pytorch copied to clipboard

[Inductor][CPP] Add Min/Max with VecMask

Open leslie-fang-intel opened this issue 1 year ago • 1 comments

Stack from ghstack (oldest at bottom):

  • -> #126841

Summary Fix issue: https://github.com/pytorch/pytorch/issues/126824 which is missing the support of min/max with VecMask.

TestPlan

python test/inductor/test_torchinductor_opinfo.py -k test_comprehensive_clamp_max_cpu_bool
python test/inductor/test_torchinductor_opinfo.py -k test_comprehensive_clamp_min_cpu_bool

cc @jgong5 @mingfeima @XiaobingSuper @sanchitintel @ashokei @jingxu10 @voznesenskym @penguinwu @EikanWang @Guobing-Chen @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @peterbell10 @ipiszy @yf225 @chenyang78 @kadeng @muchulee8 @ColinPeppler @amjames @desertfire @chauhang

leslie-fang-intel avatar May 22 '24 03:05 leslie-fang-intel

:link: Helpful Links

:test_tube: See artifacts and rendered test results at hud.pytorch.org/pr/126841

Note: Links to docs will display an error until the docs builds have been completed.

:white_check_mark: You can merge normally! (1 Unrelated Failure)

As of commit de9c5b9603d48ba5d6126f6ae8252475fd700671 with merge base 6079c5091091d872b8dafbaa4e31a5b6194647ad (image):

UNSTABLE - The following job failed but was likely due to flakiness present on trunk and has been marked as unstable:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

pytorch-bot[bot] avatar May 22 '24 03:05 pytorch-bot[bot]

Hi @isuruf, these 2 PRs in the ghstack may have conflict with https://github.com/pytorch/pytorch/pull/124021. We prefer to land 124021 at first. Then I will rebase to land the PRs here. Does it sound good to you?

leslie-fang-intel avatar May 24 '24 01:05 leslie-fang-intel

Sounds good to me.

isuruf avatar May 24 '24 03:05 isuruf

@pytorchbot merge

leslie-fang-intel avatar May 25 '24 23:05 leslie-fang-intel

Merge failed

Reason: This PR needs a release notes: label If your changes are user facing and intended to be a part of release notes, please use a label starting with release notes:.

If not, please add the topic: not user facing label.

To add a label, you can comment to pytorchbot, for example @pytorchbot label "topic: not user facing"

For more information, see https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

Details for Dev Infra team Raised by workflow job

pytorchmergebot avatar May 25 '24 23:05 pytorchmergebot

@pytorchbot merge

leslie-fang-intel avatar May 25 '24 23:05 leslie-fang-intel

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging Check the merge workflow status here

pytorchmergebot avatar May 25 '24 23:05 pytorchmergebot

@pytorchbot revert -m "Blocks reverting of the broken PR" -c ghfirst

DanilBaibak avatar May 27 '24 08:05 DanilBaibak

@pytorchbot successfully started a revert job. Check the current status here. Questions? Feedback? Please reach out to the PyTorch DevX Team

pytorchmergebot avatar May 27 '24 08:05 pytorchmergebot

@leslie-fang-intel your PR has been successfully reverted.

pytorchmergebot avatar May 27 '24 08:05 pytorchmergebot

Hi @leslie-fang-intel! Sorry, I need to revert your PRs because they block reverting of broken PR. Please rebase your PRs and merge them as soon as CI is green.

DanilBaibak avatar May 27 '24 09:05 DanilBaibak

@pytorchbot rebase

isuruf avatar Jun 11 '24 04:06 isuruf

@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here

pytorchmergebot avatar Jun 11 '24 04:06 pytorchmergebot

Rebase failed due to

Aborting rebase because rebasing the branch resulted in the same sha as the target branch.
This usually happens because the PR has already been merged.  Please rebase locally and push.

Raised by https://github.com/pytorch/pytorch/actions/runs/9459495597

pytorchmergebot avatar Jun 11 '24 04:06 pytorchmergebot

@pytorchbot merge

leslie-fang-intel avatar Jun 18 '24 00:06 leslie-fang-intel

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging Check the merge workflow status here

pytorchmergebot avatar Jun 18 '24 00:06 pytorchmergebot