pytorch icon indicating copy to clipboard operation
pytorch copied to clipboard

Remove assertion for cat target_func

Open muchulee8 opened this issue 9 months ago • 2 comments

Summary: We remove the assertion for target_func being cat. The reason is that we have multiple flavors of concat, such as cat/cat.default/cat_slice/cat_slice_cat/... Assertion here is causing multiple times of false positives.

Test Plan: Removing assertion code only.

Differential Revision: D56971387

cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @peterbell10 @ipiszy @yf225 @chenyang78 @kadeng @ColinPeppler @amjames @desertfire @chauhang

muchulee8 avatar May 04 '24 23:05 muchulee8

:link: Helpful Links

:test_tube: See artifacts and rendered test results at hud.pytorch.org/pr/125540

Note: Links to docs will display an error until the docs builds have been completed.

:white_check_mark: You can merge normally! (2 Unrelated Failures)

As of commit 802d61f8fba3500699603048d94e62fad231c0e9 with merge base 6d30803d64953955df63da56833bf4eb52249aae (image):

FLAKY - The following job failed but was likely due to flakiness present on trunk:

BROKEN TRUNK - The following job failed but was present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

pytorch-bot[bot] avatar May 04 '24 23:05 pytorch-bot[bot]

This pull request was exported from Phabricator. Differential Revision: D56971387

facebook-github-bot avatar May 04 '24 23:05 facebook-github-bot

@pytorchbot merge -f 'Landed internally'

(Initiating merge automatically since Phabricator Diff has merged, using force because this PR might not pass merge_rules.json but landed internally)

facebook-github-bot avatar May 05 '24 18:05 facebook-github-bot

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging Check the merge workflow status here

pytorchmergebot avatar May 05 '24 18:05 pytorchmergebot