pytorch icon indicating copy to clipboard operation
pytorch copied to clipboard

Fix logic to find sbgemm in BLAS library

Open vinithakv opened this issue 9 months ago • 1 comments

Current logic to set the HAS_SBGEMM flag is ignored in case the BLAS libraries are found already, ie, if set from environment variable BLAS=OpenBLAS . If BLAS_LIBRARIES are already set the code to find if BLAS_LIBRARY has sbgemm is never executed. The following commit brings out this logic outside unconditionally.

Fixes #ISSUE_NUMBER

cc @frank-wei @jgong5 @mingfeima @XiaobingSuper @sanchitintel @ashokei @jingxu10

vinithakv avatar Apr 30 '24 12:04 vinithakv

:link: Helpful Links

:test_tube: See artifacts and rendered test results at hud.pytorch.org/pr/125227

Note: Links to docs will display an error until the docs builds have been completed.

:white_check_mark: No Failures

As of commit b60721adf6e76f5d1529b4af8f1de378e9250fb9 with merge base f5328542b5365741176e71dd8a2954e0f350b9bc (image): :green_heart: Looks good so far! There are no failures yet. :green_heart:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

pytorch-bot[bot] avatar Apr 30 '24 12:04 pytorch-bot[bot]

Hi, Requesting for review .

Regards, Vinitha

vinithakv avatar May 14 '24 10:05 vinithakv

Hi @malfet , @cpuhrsch

Could you please review this patch ?

vinithakv avatar Jun 06 '24 14:06 vinithakv

@pytorchbot merge -r

malfet avatar Jun 06 '24 14:06 malfet

@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here

pytorchmergebot avatar Jun 06 '24 14:06 pytorchmergebot

Successfully rebased findBLASissue onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via git checkout findBLASissue && git pull --rebase)

pytorchmergebot avatar Jun 06 '24 14:06 pytorchmergebot

Merge failed

Reason: This PR needs a release notes: label If your changes are user facing and intended to be a part of release notes, please use a label starting with release notes:.

If not, please add the topic: not user facing label.

To add a label, you can comment to pytorchbot, for example @pytorchbot label "topic: not user facing"

For more information, see https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

Details for Dev Infra team Raised by workflow job

pytorchmergebot avatar Jun 06 '24 14:06 pytorchmergebot

@pytorchbot label "topic: not user facing"

vinithakv avatar Jun 08 '24 06:06 vinithakv

Hi @cpuhrsch , May I know why the merge is blocked still ? Please let me know if anything else needs to be done.

vinithakv avatar Jun 11 '24 08:06 vinithakv

@cpuhrsch

Hi @cpuhrsch , May I know why the merge is blocked still ? Please let me know if anything else needs to be done.

Hi @cpuhrsch Any update on this ?

Regards, Vinitha

vinithakv avatar Jun 24 '24 07:06 vinithakv

@cpuhrsch

Hi @cpuhrsch , May I know why the merge is blocked still ? Please let me know if anything else needs to be done.

Hi @cpuhrsch Any update on this ?

Regards, Vinitha

Hi @cpuhrsch @malfet @mingfeima Can I get help on getting this change merged ?

vinithakv avatar Jun 25 '24 16:06 vinithakv

@pytorchbot merge

cyyever avatar Jun 25 '24 16:06 cyyever

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging Check the merge workflow status here

pytorchmergebot avatar Jun 25 '24 16:06 pytorchmergebot