pytorch icon indicating copy to clipboard operation
pytorch copied to clipboard

Allow linalg.lstsq to use svd to compute the result for rank deficient matrices.

Open ZelboK opened this issue 10 months ago • 6 comments

Fixes #117122

This PR adds the logic so that in the case of rank deficient matrices, it can fallback to an SVD backend for batched mode. A big thank you to @tvercaut for the well written issue and suggestion on how to approach the problem.

Summary:

  1. At the time of writing this I haven't touched non-batched yet. I am hoping to get some feedback before proceeding.
  2. I believe there should be eyes on how specifically we want to fallback to SVD as the implementation when we run into rank deficient matrices.

Please keep in mind this is my 2nd PR to pytorch, and I've never really used pytorch. I'm learning independently through digging deep in the internals so I may make some obvious mistakes. Please forgive!

cc @gujinghui @PenghuiCheng @XiaobingSuper @jianyuh @jgong5 @mingfeima @sanchitintel @ashokei @jingxu10 @min-jean-cho @yanbing-j @Guobing-Chen @Xia-Weiwen @snadampal

ZelboK avatar Apr 28 '24 00:04 ZelboK

:link: Helpful Links

:test_tube: See artifacts and rendered test results at hud.pytorch.org/pr/125110

Note: Links to docs will display an error until the docs builds have been completed.

:white_check_mark: No Failures

As of commit 454d0d4b147057b3483aa0af71494b47634cb7e2 with merge base 4d063c8e8aa6be1b0b249ffedc3fd24f2aed2113 (image): :green_heart: Looks good so far! There are no failures yet. :green_heart:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

pytorch-bot[bot] avatar Apr 28 '24 00:04 pytorch-bot[bot]

@janeyx99 @ptrblck

2nd PR! 🎉 Sorry it took me some days. I'm learning Pytorch internals independently so I'm still learning the codebase.

Also I'm curious to know if there's a community like slack or discord for Pytorch?

ZelboK avatar Apr 28 '24 01:04 ZelboK

mind cleaning up all the spurious new lines and the PR in general?

lezcano avatar Apr 28 '24 04:04 lezcano

@lezcano

My apologies! I've cleaned it up. I missed some new lines from when I was cleaning up my debugging/experimenting code so I could understand the codebase.

ZelboK avatar Apr 28 '24 09:04 ZelboK

@lezcano

So when it comes to the tests, what kind of test did you think would be appropriate, aside from checking that it no longer throws? I can add gelss as a driver to be used in test_linalg_lstsq_batch_broadcasting for example and assure its results are as expected. I'm not too familiar with the test suites yet so hoping for guidance here.

Edit: Workflow runs exposed two failing tests for CPU and complex lstsq computations. I didn't notice I didn't build with LAPACK, so these tests were skipped. Will look into it now.

ZelboK avatar Apr 28 '24 16:04 ZelboK

@cpuhrsch @lezcano Could one of you please run the pipeline / tests workflow to see if perhaps these tests are flaky on my environment for whatever reason?

ZelboK avatar May 01 '24 12:05 ZelboK

CLA Missing ID CLA Not Signed

  • :white_check_mark: login: ezyang / name: Edward Z. Yang (6fc852410374dadff93d8da22955dfc30ebd7419, f1897d40eb3a6bc6a3bc6947e26b78f03d3bbeb5, 4c93c7aa96d0419720c5ea8903c230f1956a1e77, 9e2b89969286719f9f50f3c3bdeabacdfe06eede, a2e8b909ee859dd5bea7f6c97f9a349556941fe1, 0658670e33829275026507401452537808fc1822, db73a01c545a84163880b6e8dbafb9c5336ff32f, 421b23d41cb1bbe96e01065c9fb4bba71fb24a00, 3fe0c6d148b8e0f9f5b3044d45ea0723e1b020a4, f33cc7ac340514ccbad2a975ec8f8e103634a4c0, 6b733b2908ad4e5960d5932d3c1afd35c9845ccb, 726389305a775a5ef0842a32b76fa244fe1ba2a5, 8989a88b6be816c49cc8bc509498303f092e3f44, 197ebc5be2df4da680af49f3c898fce6426e0096, 2d65795e80b75510993a9c36ac26c5d9677657a8)
  • :white_check_mark: login: wz337 / name: Iris Z (479f3f9656f85ab2d1f65c55203833b238da1258, 9b24e7f0fad922c7febaaa4736e5fb99c8736897, 99190daf62bf57567a893f1290f6fd75cbd9f753, 0f31e61295ea6ab54df9279d4fd1e4c32599e81b)
  • :white_check_mark: login: yanboliang / name: Yanbo Liang (b24a9e3ad818a8aeb4dc6b8abaf82f02ed020f79, 22c50a3960b691b9ed9c64b6dc5f61241b54cdcd, 976f0f2b1ef00eab09d0ffb0c9ad73bd6bc9f296, 7754cc1ced269bbdd7e212af505bdae518a8dc2e, 685b207a4c91d1d1bbc59b53347c5fba5e342624, b10f3ddc4ddd0241af70e18890f5dd186c7f31de)
  • :white_check_mark: login: kiukchung (00b99743c23ae1b8fe16c3b984bd22bf5e85bc35)
  • :white_check_mark: login: guangyey / name: Yu, Guangye (22b4b228d6196e54d4b3b633c7e2b7f18472dc78, 45d93f997d056e895ff6d43c2fa1b6d9d87609e7)
  • :white_check_mark: login: dvrogozh / name: Dmitry Rogozhkin (a2e563d488a973647f93321f9c9041bf38c8ae18)
  • :white_check_mark: login: ZelboK / name: Danial Javady (c71e5047e85aeca77ae1555dcde1155f677c72f5, 3006f3054147954d78827f86518d88a8fef6cc59, e0fec866a38d2b89c0653cf52aa887a240d106a0, 99e7cfbbb5b99e9c5417394377a260ba4847eba3, de502bcdc4b5992f72225e5960db5c16c31f5706, c856b9ef12fb956b4919d11f17c1b37fa0d63faa, bb20952b487981e99cdf9b85456fa005c885aeda, 7372645096d5f8a00e437c77ed04dc1123f1344e, d5b0174eda7b6c495ca3df3f392d0469acd57337, da8145949d55e14333e9bca7d44b889581a7b122, b6d6086db95ed780b412ae62cc5712f0f6f3dbc7, 755e7d967dd41fc39cb751f81b38ca30e70b31eb, 428f02abbfc63bce315da57a182dbb6a5354630c, 4eab1c325509d10305ba46a999043b64cf1311e1, fec979385bb9c129be9cbcab3c1b9f2eedccd68a, 6e8b3fdac9c7975eb49a076c74f324a6cc8bee6e, 489afbe973c81f3fe39823f5b601bec5126251c9)
  • :white_check_mark: login: david20571015 / name: David Chiu (079d3f5e4e588ceb2dd563d12bbb4428a2d88171, e1a06766bbf1647a2e6b69303405de928cb1e5a4)
  • :white_check_mark: login: williamwen42 / name: William Wen (2524635cbe48a307ccf830f1529635752aa498e6, 972f76f0825a87bcb53be775e726af84250a992a, 8cc3b81bceeab8891521cff07ea868cba458927d, 19e79243adeff90d798e4664a4204f31cb19ec5e)
  • :white_check_mark: login: yihanhemeta (a6235d009b4da8106bd2be82b969d1c8847bb280)
  • :white_check_mark: login: pytorchmergebot (f30d086e08ba8b8a3e1ade2ddbd531aced469320, c81bf77bce5c116bc6e50e82cdebd9a27c7827a6, 930e757eebeb3a2cbe325f612d6c0b716be438c6, 2a6c92a0e07071443adc3d6281683c21d1200598, 8f51cf73384b2f75e131339cc9c3eb5068e89473, fa207b55a167c33f21e2fd0b5b0594b6a642e815, 2f044a872ce2676d448709c5bde3d5ccdf207d5b, 02bf7e2f925299d32b23b3670320bdf81a19dfba, ff266cdd61da59227b2b4abefc57c6c5cc64f2d6, 921a82451fda81b55c3d635b21fc89300508b9cb, dd2f8d1f72a6ea322582834c22e18727e7558c91, 75289f21c3fd483aad703143e7d364fdc4ceb47e, a95b7e907f910c7fe7d909ccd10266b58e423d71, 4397921432b8a1fe1ca819d40d3780cff3b8951d, 195d01cf13e439385d4d7712144d1bd849caf947, 50b88b057ea23c8e1207018df8f311af0df2771a, 0ac2cec0b57c355b48b8199f8947830fcca56063)
  • :white_check_mark: login: ydwu4 / name: Yidi Wu (636ea1c2fe2c387f385f150ce10f8eb9c076ef47, 814dbc795ba981de5edc7fb21e8a10f6933f1ad0, a74500328cb1f7ccfde104b2fba563eda243f1e1)
  • :white_check_mark: login: weifengpy / name: Wei (Will) Feng (592bc1f433adcb66ca2f60280260f6ac72242227, 5b4dea2b37f9587d4163c539cb00638e816c5e8d)
  • :white_check_mark: login: manuelcandales / name: Manuel Candales (68a6cdd8e4981c23fa6300e2da330ab9c1ded25f, fbf80183d92a0fb5c4d255de748bf3f49cac3186)
  • :white_check_mark: login: anijain2305 / name: Animesh Jain (b8c08b6247c1636c4ccb66f686064d58bef0ab9c, d3d25a34adb437989cd8e3ede3b894522b433cbb, ae2fdc8133f56ae2f1562ea983c83c2bfa4a26ac, 009b5b6bd016686e3c109914aa852ea9c4eac45d, 3a3f8a9bbae3184542ce06f7c22ca4b80457b122, 8f9fa4712e14aa30fe0b1087c05e533371564542, f2098653b1500d9353033e887497b0892c9f6b8d, 10b10f2b6bb3659c6d81e5a679f5bf96036fbdf7, 8dced59e360970afa671714b302f0e262924ac86, edbd215f3566bc8bdcf3a1db05d12e6b4197cfb3)
  • :white_check_mark: login: mikaylagawarecki (b9da19d68f4c48c3f795ea720fdc506e9e070234, d0d2d0bcf4e735940b902a3f1bc8301f6526b728)
  • :white_check_mark: login: amjames / name: Andrew James (6e4ed6cf11f9df889c199d5c1111e1efb3fef64a)
  • :white_check_mark: login: petrex / name: Peter Yeh (63727709a87ff4e548efd74ec6821bcdf150b009)
  • :white_check_mark: login: jiashenC / name: Jiashen Cao (45a699a38f911c2947a7003d47e775bf8ba2b6e5, d82bbb0dccd37db31136edc60874ff90c18da4a2)
  • :white_check_mark: login: cyyever / name: cyyever (eb5e9ed827e34a26d12d181e3ec4aadfb0b8e9a6, 9882241987738e2aab854497e0880ff2cb63f0a2, 86d560aa8a5a11767629bd5687bcff9e5373e3c8, 454d0d4b147057b3483aa0af71494b47634cb7e2, 743df86707b7329f370e4dfe54d7b24139ccc0d5)
  • :white_check_mark: login: awgu / name: Andrew Gu (b6d82019037bb0f804805efbb048f6f03d77a651, 939738001ba764b152742e6c6782372de47301d9, 9a47caa970a5789d8b6f9c63719d3711ccacd03c, 5dd875a580ed7bfaad0229c3f642b73506d5015e)
  • :white_check_mark: login: Skylion007 / name: Aaron Gokaslan (5182e2e3695508d623c82d94b501d3130d48cafa)
  • :white_check_mark: login: clee2000 (a1245dd47415c5de49d5ac14f550deb6384d2941, 0df5ed0cc523d7831e804fa6b0f6b4e2d44d4e3c, 910f26f92c793beb23f78235ff798d415d19ca3b, e49ccce79754f7abaf8e0cf20631e6398d244259, 45a8ba420739e2b26a84d3ffd8f118fab976cf5b)
  • :white_check_mark: login: zxd1997066 / name: xiangdong (0d9def070c6ca52504ac0646814e066b3ef0db7c)
  • :white_check_mark: login: tugsbayasgalan / name: Tugsbayasgalan Manlaibaatar (04c3751b6f0d1f5020cfeb3aa09bebd479e2b650, 0f2db1ce0df0c67145ca6c304d5fd9c3cea2a8df)
  • :white_check_mark: login: huydhn / name: Huy Do (b3f0fce00b5244314e976c0cde0cce6985b0f68c, 7dab5f7c6dd49ed9c4fc7657c3032b7a61fbef27, adc05514ebc9ae1b22d39d6e3be4fbeb8bc08b26, 0e59bd4c8a9d1533c74aba3aee634a944d6b250a)
  • :white_check_mark: login: eqy (75add2fa2cbb91b5fa8e8017b8ea097081e6f71e)
  • :white_check_mark: login: tringwald / name: Tobias Ringwald (f4daf9ec8fa9fe22b4b5bdb29b91e5cee4e63f3c, fed9d936ebca6083b72867db72ca6985b7c85754)
  • :white_check_mark: login: Aidyn-A (4417b4c2eedb45d44c326df5b8baaf4ac08d2518)
  • :white_check_mark: login: angelayi / name: Angela Yi (65f4d4fde82c3427057ddb62245f396a80530eaf)
  • :white_check_mark: login: jgong5 / name: Jiong Gong (88643f1cfd9d2c71e9ef95fe5b873ff6ea02a1ed, b743f89208c3b676206d7217d45ddd16c244b7c6, e974908186c1c6b7bcd951e446b9ba613fe02e78)
  • :white_check_mark: login: gustavla / name: Gustav Larsson (2a344655812ff2f9bdc50781bf69816330f5de65, 569ee1efb1c3f5601ace93d11d0253655b70a095, 3ca1ae445a20f10ee6a0544cca13d71874ca3583)
  • :white_check_mark: login: fegin / name: Chien-Chin Huang (667af78e123e154641837dec8190628a4d32c47f, 08e5a7e695038ed51fe4f81b3559aa410db6533a)
  • :white_check_mark: login: adelesun (0e2256602fafeb7246e1ac40b1031700d9e2eaf4)
  • :white_check_mark: login: drisspg / name: Driss Guessous (7cea4a51b12ae2ad2a1daa5df914474854506523, 1dfe2d11f8ba8678df53dde4de143e3af1bca98d, 22db67f54ca52c2239633dd7c0656ead144b7411, 23b6ebd947bf7e8681ecf0875683a8826a1956a1)
  • :white_check_mark: login: shink / name: Yuanhao Ji (05eff3593a26616107aac2026da9c3677662c4d8, 255ae5dde7927f71fab5e39873abdb2254fbeabb, 68c29aac7762f6523fc7c181cc94ed4ce30ffc93)
  • :white_check_mark: login: masnesral (675c49f52cfc7ae2749bcd6de6e25e49e9ee3e40, 39f5adb3dac83382f5a974a69ff494617aa5b54e, bc9f57ba4c951efd3be1ed3b4c50aaee59481a5c, 38e26618f1591af838e980e2d5e808cd9a6541c9, 32fdb75848b79deb54cf4ced92d8ad40694e0fe4)
  • :white_check_mark: login: PaliC / name: Sahan Paliskara (782792bd6d74f61dcca4c6c51259216ce0186984)
  • :white_check_mark: login: kwanghoon-meta (b2aff2052a147f89334a4d99c6a27d8a702aa495, a4250cc00fcb0655c54ae9a1046507c272c92f9c)
  • :white_check_mark: login: desertfire / name: Bin Bao (272b1194dd86656b744ab205c392125356a8c8c6, 5bc525c98872d9d77cf1724e6da1d49f1f30fecb, 8dc8ae9073e7455e35bf48946dfb04054df1378c, d27e21dd3e697aeda4ed60dab99e9af295b2775f, 27b738124c7bdf86ce2d5281e9be910b4fcdc8b8, 7e7392bfb6b64b16d83dd8342ab26f9514d21176)
  • :white_check_mark: login: jbschlosser / name: Joel Schlosser (6243a43fb8752c1a034d54428649a57017f533c9)
  • :white_check_mark: login: malfet / name: Nikita Shulga (12f2960876e03b600b0fcebbc4165c9d42ccf8a0, e24f7b3a5bca19a1c25649bbb76ec0f413422c94, adf9cc7c97680340079ad4d9cdc1739599891582, cebb5dfd6875b08147c531f265ba850fa57d78aa, 38a85b2f27aef2695e0f23a4a8035ada640bdb2f)
  • :white_check_mark: login: zhuhaozhe (694459376ee1b2ed6b161dc1cbe4dd849b2643db)
  • :white_check_mark: login: pianpwk / name: Pian Pawakapan (93d25739a90851c8a378c28930cdfb7e812d726d)
  • :white_check_mark: login: isuruf / name: Isuru Fernando (8221d3d3f9d62ee957a75e4abb8db97c22cf3994, 11aea9e3919b9751d0e49a08e6b72e76850e8476, 9f09eae92eae2eebe86fc668b0c558edf5a956a5)
  • :white_check_mark: login: StellarrZ / name: Ze Sheng (7a4c6b9a40f02750f11b17dd17b6d8cfb82fd3c5)
  • :white_check_mark: login: briancoutinho / name: Brian Coutinho (45a3349ff0d19bf8605d287d69241252eaa8dc69, 37f84cb2388110ed450ead70ccef21bc9b557e25)
  • :white_check_mark: login: eellison (4f024c8cb445c5cafbb495ac8a0b13ede0e1f87e, 2cbbe21a87e155d3d7e68b74f116899e1a8e429f, b3b9f7214ff45209187a7008bb121d6afa07ae1e, 0ce75f9449c2090eace75a47da1a39034d4c9741, be7b65a5c779a1b0c554272f913e46af39b58916, a749763eb4e0884274e1a379fc44ab505d0e0e86)
  • :white_check_mark: login: MatzeB / name: Matthias Braun (19482258268dd8e4e13a30d5f855213bb0c03e9f)
  • :white_check_mark: login: Stonepia / name: Stonepia (b1770bd1f883f6a36c8fa0b6e9a0f4d8ffdf752c)
  • :white_check_mark: login: shuqiangzhang / name: Shuqiang Zhang (3bbd7fac2a5dadc0ed93bf45453e6a6e5407db8d, 2ba6d3763d2a3699e64af1b7203603296d6df326)
  • :white_check_mark: login: andrewor14 (218756f064c5b373f7da875bd2b36d84bc7a6615)
  • :white_check_mark: login: hongyang-zhao (2b7ac1e8928c2111070857f883f887eabf573bb9)
  • :white_check_mark: login: albanD (a0a6bbc68df0061401ea46011f0168a866592970, 147ba731b251df30f85fc27a987c15f334c85179)
  • :white_check_mark: login: ColinPeppler / name: Colin Peppler (bb5e037a9d91d61d108328a169b4a570d62faa8c)
  • :white_check_mark: login: aaronenyeshi / name: Aaron Shi (4e3dfb0ffa9690e4c16d7607bc3cdec9fd0ca3ed)
  • :white_check_mark: login: Chillee / name: Horace He (c271827506f042334d61a20b312059d9ca7e1cf0, 367a0c5a8b67dd66455368bc794469e4f49117ab)
  • :white_check_mark: login: r-barnes / name: Richard Barnes (cd767857ed474bf0c15167bfe26d729b9797e842)
  • :white_check_mark: login: davidberard98 / name: David Berard (ac162de6a3e4f386fb505ab6f668b51cf0363c8b)
  • :white_check_mark: login: ringohoffman / name: Matthew Hoffman (bd10ff68f72ba1894b21efe2f3290b9e12712c10)
  • :white_check_mark: login: LucasLLC / name: Lucas Pasqualin (b5e622063eb9ec8179dc16c958e1519e16d040c9)
  • :white_check_mark: login: etaf (cd608010d80de5df73674e465e6b2aab82121943, d0688dd5bed6210f8ef11b1d2c89199493cbee2e)
  • :white_check_mark: login: zhxchen17 / name: Zhengxu Chen (a48463ebb5a0f2d25ddbf727ba3a91da8706964c)
  • :white_check_mark: login: wconstab / name: Will Constable (ae7ee03deb85f9602fe906268bd6f1b35b93efe0, b6caa1599fc636a68c8adefc240fa435491262eb, 8ab08f90ef45f8b38e13be71fa135ac702263a0d, 492ef493e8f0ece367138e98505ed638724c64f0)
  • :white_check_mark: login: yf225 / name: Will Feng (74ad455d6f1ec8325f8185b89dd285775f667a5e, 64efc14c705a5c0eb1c27f0a080cbf43f67ea90d, b4a22887e9bd8de614c416f14403d68ac41602bc)
  • :white_check_mark: login: xmfan / name: Simon Fan (b29fd1fc25fc7af233ae7f1dcad24acdc70aa750, b2efbae485d6e5d3663b3114483b8517dbad12c4, 80798a76088b60100fbe6377ddda9d17c76821fb, 0d1108ccb023dcfce9bd0825d34139fe9904e60e)
  • :white_check_mark: login: d4l3k / name: Tristan Rice (a05c0fa18911991c1fea8c50de45df84878272e7, d288e442655f058ad345d7cdfa325374927ef51c)
  • :white_check_mark: login: pytorchupdatebot / name: PyTorch UpdateBot (ce7a8329a078485c2ffe10fa73eed366e706fb84)
  • :white_check_mark: login: hippocookie / name: zong (1480537b9bad8f64c1db5a8f503f176ae960cb73)
  • :white_check_mark: login: Xia-Weiwen / name: Xia Weiwen (747bdea564d767c9788b649f8bae471b6aa4f639, 8288174c5d9209ac9904135783fe913a85150e0a)
  • :white_check_mark: login: AlexDenisov / name: AlexDenisov (54ce30670c0109b240ea0d5d3342a40b814ffdfa)
  • :white_check_mark: login: oulgen / name: Oguz Ulgen (351289596fb7e193a6a91e7f65bf3c70be178ccf)
  • :white_check_mark: login: 1274085042 / name: FEI (074173beb1367f2a2e4c93415f05894887ed11e0)
  • :white_check_mark: login: jithunnair-amd / name: Jithun Nair (60fb3ef7acd258db4ead46974ed6c258ea547f84, 19dfbce5bd21f869287eaee78d24c74dd7db2084)
  • :white_check_mark: login: jamesjwu / name: James Wu (3f1ccfd30d22d6080b1f12ffadbf935361fa6f1d, 39b27952e4424365c2ac4bb4950431409db446b3)
  • :white_check_mark: login: nWEIdia / name: Wei Wang (170380e58ae3976dffa405cca7de932db9dd44d6)
  • :white_check_mark: login: vanbasten23 / name: iefgnoix (b959b4f9db09c19fa7237ea488ad255e2e34bdad)
  • :white_check_mark: login: tarun292 / name: Tarun Karuturi (1367209a3e488c309d10c08c9b86688041ca8c5d)
  • :white_check_mark: login: izaitsevfb / name: Ivan Zaitsev (147347226aed1842a97c1f431f516cf151bb7abe)
  • :white_check_mark: login: CaoE / name: Cao E (ae3c9cadfad2b0ef9746243b147fbf26d440ecb0)
  • :white_check_mark: login: yuanx749 / name: Xiao Yuan (0ddafc0c6a782e6144ba649a78484fe6ce42cced)
  • :white_check_mark: login: guilhermeleobas / name: Guilherme Leobas (0be8b0f4eed227990cde233833e77c7044607454)
  • :white_check_mark: login: alugorey / name: Andres Lugo (9df7bdab89d8941f896f9e2663ab403b6713bd5b)
  • :white_check_mark: login: SherlockNoMad / name: Sherlock Huang (bd786d8e65c58d355619b789be4a5ee2c485a07b)
  • :white_check_mark: login: Martim03 / name: Martim Mendes (67085195726d929699c657abe524733e9ac5331c)
  • :white_check_mark: login: wanchaol / name: Wanchao (c73f90c8b0012e57fa93de3dd27a42c61aca635a)
  • :white_check_mark: login: nmacchioni / name: Nicolas Macchioni (f55c0cce9d35c0b8ff05803d5436acd6089a746c)
  • :white_check_mark: login: EikanWang / name: Eikan Wang (fb2c753d601d75e893c7e9e66b07b2f3c819f846, b51e6ddae240dff642a71f8804798b0710778a63)
  • :white_check_mark: login: c-p-i-o / name: Chirag Pandya (aa17484d6de9cfce3b6f8f848380971c149fe299)
  • :white_check_mark: login: H-Huang / name: Howard Huang (ed27236adf9db2aff73faacdcda111d149854a6a)
  • :white_check_mark: login: gambiTarun / name: Tarunbir Gambhir (6ed6142e510e63454521a4416644aace4668ce6a)
  • :white_check_mark: login: Flamefire / name: Alexander Grund (35117bf6bd9763f949754e50eea10fdbcfbe2593)
  • :white_check_mark: login: lvaleriu / name: Valeriu Lacatusu (64fb6edd84bbefb8017a8e4e4de14061221a092b)
  • :white_check_mark: login: ktsiam (4de26b7a612d8658a5c78351d29b5e8a985f9fb8)
  • :white_check_mark: login: kwen2501 / name: Ke Wen (68ff312eb83333ed2b4b251cb7b571e2332ea3df)
  • :white_check_mark: login: swolchok / name: Scott Wolchok (8a7f71942064f4a52608f69c379580b2508a3bb8)
  • :white_check_mark: login: tianyu-l (c61bdbff7fbe0a94c0b60c3266db1deb171757bb)
  • :white_check_mark: login: jansel / name: Jason Ansel (deb6f3fef92094b79b8f836857e1368b5bb75987)
  • :x: The email address for the commit (05eff3593a26616107aac2026da9c3677662c4d8, 694459376ee1b2ed6b161dc1cbe4dd849b2643db, de502bcdc4b5992f72225e5960db5c16c31f5706, bb20952b487981e99cdf9b85456fa005c885aeda, 8288174c5d9209ac9904135783fe913a85150e0a) is not linked to the GitHub account, preventing the EasyCLA check. Consult this Help Article and GitHub Help to resolve. (To view the commit's email address, add .patch at the end of this PR page's URL.) For further assistance with EasyCLA, please submit a support request ticket.

bad rebase. Too many people are tagged now. Open a new PR.

lezcano avatar May 19 '24 19:05 lezcano