pytorch icon indicating copy to clipboard operation
pytorch copied to clipboard

[DTensor] Turn on foreach implementation of optimizer for DTensor by default

Open wz337 opened this issue 10 months ago • 10 comments

Append DTensor to the optimizer _foreach_supported_types and turn on foreach implementation of optimizer for DTensor if not specified by the users.

cc @mrshenli @pritamdamania87 @zhaojuanmao @satgera @rohan-varma @gqchen @aazzolini @osalpekar @jiayisuse @H-Huang @kwen2501 @awgu @penguinwu @fegin @XilunWu @wanchaol @fduwjj @tianyu-l @wconstab @yf225 @chauhang

wz337 avatar Apr 04 '24 22:04 wz337

:link: Helpful Links

:test_tube: See artifacts and rendered test results at hud.pytorch.org/pr/123394

Note: Links to docs will display an error until the docs builds have been completed.

:white_check_mark: You can merge normally! (2 Unrelated Failures)

As of commit f907706e7d2c9e120fb7265e4ece80d54f45786a with merge base 1a28f731dc6a1d7db04518a74858f0282b686375 (image):

FLAKY - The following jobs failed but were likely due to flakiness present on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

pytorch-bot[bot] avatar Apr 04 '24 22:04 pytorch-bot[bot]

@pytorchmergebot rebase

wz337 avatar Apr 04 '24 23:04 wz337

@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here

pytorchmergebot avatar Apr 04 '24 23:04 pytorchmergebot

Successfully rebased turn_on_dtensor_foreach onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via git checkout turn_on_dtensor_foreach && git pull --rebase)

pytorchmergebot avatar Apr 04 '24 23:04 pytorchmergebot

@pytorchmergebot rebase

wz337 avatar Apr 19 '24 17:04 wz337

@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here

pytorchmergebot avatar Apr 19 '24 17:04 pytorchmergebot

Successfully rebased turn_on_dtensor_foreach onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via git checkout turn_on_dtensor_foreach && git pull --rebase)

pytorchmergebot avatar Apr 19 '24 17:04 pytorchmergebot

@pytorchmergebot rebase

wz337 avatar May 10 '24 21:05 wz337

@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here

pytorchmergebot avatar May 10 '24 21:05 pytorchmergebot

Successfully rebased turn_on_dtensor_foreach onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via git checkout turn_on_dtensor_foreach && git pull --rebase)

pytorchmergebot avatar May 10 '24 21:05 pytorchmergebot

@pytorchmergebot merge

wz337 avatar May 15 '24 09:05 wz337

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging Check the merge workflow status here

pytorchmergebot avatar May 15 '24 09:05 pytorchmergebot

@pytorchmergebot merge

wz337 avatar May 15 '24 16:05 wz337

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging Check the merge workflow status here

pytorchmergebot avatar May 15 '24 16:05 pytorchmergebot