pytorch icon indicating copy to clipboard operation
pytorch copied to clipboard

Fix compiler check

Open xuhancn opened this issue 1 year ago • 8 comments

Fixes #119304

  1. Add try catch to handle the compiler version check.
  2. Retry to query compiler version info.
  3. Return False if can't get compiler info twice.

cc @jgong5 @mingfeima @XiaobingSuper @sanchitintel @ashokei @jingxu10

xuhancn avatar Feb 23 '24 15:02 xuhancn

:link: Helpful Links

:test_tube: See artifacts and rendered test results at hud.pytorch.org/pr/120492

Note: Links to docs will display an error until the docs builds have been completed.

:white_check_mark: You can merge normally! (1 Unrelated Failure)

As of commit 6969679564e7be9cf583e11404549112225d7ca4 with merge base b96ea097ee7b2730a21d3954975a3636d08fd054 (image):

UNSTABLE - The following job failed but was likely due to flakiness present on trunk and has been marked as unstable:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

pytorch-bot[bot] avatar Feb 23 '24 15:02 pytorch-bot[bot]

@pytorchbot rebase

xuhancn avatar Feb 23 '24 15:02 xuhancn

@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here

pytorchmergebot avatar Feb 23 '24 15:02 pytorchmergebot

Successfully rebased fix_compiler_check onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via git checkout fix_compiler_check && git pull --rebase)

pytorchmergebot avatar Feb 23 '24 15:02 pytorchmergebot

@pytorchbot merge

ezyang avatar Feb 24 '24 22:02 ezyang

Merge failed

Reason: This PR needs a release notes: label If your changes are user facing and intended to be a part of release notes, please use a label starting with release notes:.

If not, please add the topic: not user facing label.

To add a label, you can comment to pytorchbot, for example @pytorchbot label "topic: not user facing"

For more information, see https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

Details for Dev Infra team Raised by workflow job

pytorchmergebot avatar Feb 24 '24 22:02 pytorchmergebot

@pytorchbot merge

ezyang avatar Feb 24 '24 23:02 ezyang

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging Check the merge workflow status here

pytorchmergebot avatar Feb 24 '24 23:02 pytorchmergebot

@pytorchbot label "topic: not user facing"

xuhancn avatar Feb 25 '24 02:02 xuhancn