pytorch icon indicating copy to clipboard operation
pytorch copied to clipboard

partial fix for buffer mutations with aot_compile

Open bdhirsh opened this issue 1 year ago • 2 comments

Partial fix for https://github.com/pytorch/pytorch/issues/120424. @int3 to continue investigation.

Stack from ghstack (oldest at bottom):

  • -> #120427

cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @peterbell10 @ipiszy @yf225 @chenyang78 @kadeng @muchulee8 @aakhundov @ColinPeppler @amjames

bdhirsh avatar Feb 22 '24 19:02 bdhirsh

:link: Helpful Links

:test_tube: See artifacts and rendered test results at hud.pytorch.org/pr/120427

Note: Links to docs will display an error until the docs builds have been completed.

:hourglass_flowing_sand: 1 Pending, 15 Unrelated Failures

As of commit cc37b48b3a5df7461b74db0837e44e282c28cd49 with merge base 9c597ff137ead9f7f7ec8fdcbf473de2d328e61b (image):

UNSTABLE - The following jobs failed but were likely due to flakiness present on trunk and has been marked as unstable:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

pytorch-bot[bot] avatar Feb 22 '24 19:02 pytorch-bot[bot]

Is @int3 gonna commandeer this? Needs test

ezyang avatar Feb 24 '24 22:02 ezyang

hm I'm gonna write a fix for inductor that depends on this fix, but I think we have two separate issues here. @bdhirsh could you write a test for the expected fx graph output that this PR fixes?

int3 avatar Feb 28 '24 21:02 int3

This PR is subsumed by https://github.com/pytorch/pytorch/pull/121688

bdhirsh avatar Mar 21 '24 13:03 bdhirsh