pytorch
pytorch copied to clipboard
partial fix for buffer mutations with aot_compile
Partial fix for https://github.com/pytorch/pytorch/issues/120424. @int3 to continue investigation.
Stack from ghstack (oldest at bottom):
- -> #120427
cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @peterbell10 @ipiszy @yf225 @chenyang78 @kadeng @muchulee8 @aakhundov @ColinPeppler @amjames
:link: Helpful Links
:test_tube: See artifacts and rendered test results at hud.pytorch.org/pr/120427
- :page_facing_up: Preview Python docs built from this PR
- :page_facing_up: Preview C++ docs built from this PR
- :question: Need help or want to give feedback on the CI? Visit the bot commands wiki or our office hours
Note: Links to docs will display an error until the docs builds have been completed.
:hourglass_flowing_sand: 1 Pending, 15 Unrelated Failures
As of commit cc37b48b3a5df7461b74db0837e44e282c28cd49 with merge base 9c597ff137ead9f7f7ec8fdcbf473de2d328e61b ():
UNSTABLE - The following jobs failed but were likely due to flakiness present on trunk and has been marked as unstable:
-
inductor / cuda12.1-py3.10-gcc9-sm80 / test (inductor_torchbench_smoketest_perf, 1, 1, linux.gcp.a100, unstable) (gh)
hf_T5
-
inductor / cuda12.1-py3.10-gcc9-sm86 / test (aot_inductor_huggingface, 1, 1, linux.g5.4xlarge.nvidia.gpu, unstable) (gh)
Process completed with exit code 1.
-
inductor / cuda12.1-py3.10-gcc9-sm86 / test (dynamic_inductor_huggingface, 1, 1, linux.g5.4xlarge.nvidia.gpu, unstable) (gh)
Process completed with exit code 1.
-
inductor / linux-jammy-cpu-py3.8-gcc11-inductor / test (cpu_inductor_huggingface, 1, 1, linux.12xlarge, unstable) (gh)
Process completed with exit code 1.
-
inductor / linux-jammy-cpu-py3.8-gcc11-inductor / test (cpu_inductor_timm, 1, 2, linux.12xlarge, unstable) (gh)
cspdarknet53
-
inductor / linux-jammy-cpu-py3.8-gcc11-inductor / test (cpu_inductor_timm, 2, 2, linux.12xlarge, unstable) (gh)
repvgg_a2
-
inductor / linux-jammy-cpu-py3.8-gcc11-inductor / test (cpu_inductor_torchbench, 1, 2, linux.12xlarge, unstable) (gh)
hf_T5_large
-
inductor / linux-jammy-cpu-py3.8-gcc11-inductor / test (cpu_inductor_torchbench, 2, 2, linux.12xlarge, unstable) (gh)
stable_diffusion_unet
-
inductor / linux-jammy-cpu-py3.8-gcc11-inductor / test (dynamic_cpu_inductor_huggingface, 1, 1, linux.12xlarge, unstable) (gh)
Process completed with exit code 1.
-
inductor / linux-jammy-cpu-py3.8-gcc11-inductor / test (dynamic_cpu_inductor_timm, 1, 2, linux.12xlarge, unstable) (gh)
deit_base_distilled_patch16_224
-
inductor / linux-jammy-cpu-py3.8-gcc11-inductor / test (dynamic_cpu_inductor_timm, 2, 2, linux.12xlarge, unstable) (gh)
repvgg_a2
-
inductor / linux-jammy-cpu-py3.8-gcc11-inductor / test (dynamic_cpu_inductor_torchbench, 1, 2, linux.12xlarge, unstable) (gh)
hf_T5_large
-
inductor / linux-jammy-cpu-py3.8-gcc11-inductor / test (dynamic_cpu_inductor_torchbench, 2, 2, linux.12xlarge, unstable) (gh)
stable_diffusion_unet
-
inductor / linux-jammy-cpu-py3.8-gcc11-inductor / test (inductor_torchbench_cpu_smoketest_perf, 1, 1, linux.12xlarge, unstable) (gh)
Process completed with exit code 1.
-
pull / linux-focal-py3.8-clang10-onnx / test (default, 2, 2, linux.2xlarge, unstable) (gh)
Process completed with exit code 1.
This comment was automatically generated by Dr. CI and updates every 15 minutes.
Is @int3 gonna commandeer this? Needs test
hm I'm gonna write a fix for inductor that depends on this fix, but I think we have two separate issues here. @bdhirsh could you write a test for the expected fx graph output that this PR fixes?
This PR is subsumed by https://github.com/pytorch/pytorch/pull/121688