pytorch
pytorch copied to clipboard
Fix `nonlinearity` arg issue in RNN
Fixes #114617
This PR fix the the issue with nonlinearity
, so that it can be passed as arg or kwarg.
Alternatively, if making nonlinearity
kwarg-only is preferred, I can revert to another commit. cc @mikaylagawarecki
:link: Helpful Links
:test_tube: See artifacts and rendered test results at hud.pytorch.org/pr/120234
- :page_facing_up: Preview Python docs built from this PR
- :page_facing_up: Preview C++ docs built from this PR
- :question: Need help or want to give feedback on the CI? Visit the bot commands wiki or our office hours
Note: Links to docs will display an error until the docs builds have been completed.
:white_check_mark: No Failures
As of commit 754accc45be267ef549237e75460fd083ad5a07e with merge base 3e382456c109820c836b104570104c3c5aff5632 ():
:green_heart: Looks good so far! There are no failures yet. :green_heart:
This comment was automatically generated by Dr. CI and updates every 15 minutes.
Sure. I added a test. @mikaylagawarecki
@pytorchbot merge
Please seek CI approval before scheduling CIFlow labels
Merge failed
Reason: This PR needs a release notes:
label
If your changes are user facing and intended to be a part of release notes, please use a label starting with release notes:
.
If not, please add the topic: not user facing
label.
To add a label, you can comment to pytorchbot, for example
@pytorchbot label "topic: not user facing"
For more information, see https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.
Details for Dev Infra team
Raised by workflow job
@pytorchbot merge
Please seek CI approval before scheduling CIFlow labels
Merge started
Your change will be merged once all checks pass (ETA 0-4 Hours).
Learn more about merging in the wiki.
Questions? Feedback? Please reach out to the PyTorch DevX TeamAdvanced Debugging
Check the merge workflow status
here
Merge failed
Reason: 3 mandatory check(s) failed. The first few are:
Dig deeper by viewing the failures on hud
@pytorchbot merge
Merge started
Your change will be merged once all checks pass (ETA 0-4 Hours).
Learn more about merging in the wiki.
Questions? Feedback? Please reach out to the PyTorch DevX TeamAdvanced Debugging
Check the merge workflow status
here