pytorch icon indicating copy to clipboard operation
pytorch copied to clipboard

Fix `nonlinearity` arg issue in RNN

Open yuanx749 opened this issue 1 year ago • 2 comments

Fixes #114617

This PR fix the the issue with nonlinearity, so that it can be passed as arg or kwarg.

Alternatively, if making nonlinearity kwarg-only is preferred, I can revert to another commit. cc @mikaylagawarecki

yuanx749 avatar Feb 20 '24 15:02 yuanx749

:link: Helpful Links

:test_tube: See artifacts and rendered test results at hud.pytorch.org/pr/120234

Note: Links to docs will display an error until the docs builds have been completed.

:white_check_mark: No Failures

As of commit 754accc45be267ef549237e75460fd083ad5a07e with merge base 3e382456c109820c836b104570104c3c5aff5632 (image): :green_heart: Looks good so far! There are no failures yet. :green_heart:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

pytorch-bot[bot] avatar Feb 20 '24 15:02 pytorch-bot[bot]

Sure. I added a test. @mikaylagawarecki

yuanx749 avatar Feb 23 '24 04:02 yuanx749

@pytorchbot merge

yuanx749 avatar Feb 25 '24 06:02 yuanx749

Please seek CI approval before scheduling CIFlow labels

pytorch-bot[bot] avatar Feb 25 '24 06:02 pytorch-bot[bot]

Merge failed

Reason: This PR needs a release notes: label If your changes are user facing and intended to be a part of release notes, please use a label starting with release notes:.

If not, please add the topic: not user facing label.

To add a label, you can comment to pytorchbot, for example @pytorchbot label "topic: not user facing"

For more information, see https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

Details for Dev Infra team Raised by workflow job

pytorchmergebot avatar Feb 25 '24 06:02 pytorchmergebot

@pytorchbot merge

mikaylagawarecki avatar Feb 26 '24 16:02 mikaylagawarecki

Please seek CI approval before scheduling CIFlow labels

pytorch-bot[bot] avatar Feb 26 '24 16:02 pytorch-bot[bot]

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging Check the merge workflow status here

pytorchmergebot avatar Feb 26 '24 16:02 pytorchmergebot

Merge failed

Reason: 3 mandatory check(s) failed. The first few are:

Dig deeper by viewing the failures on hud

Details for Dev Infra team Raised by workflow job

Failing merge rule: Core Maintainers

pytorchmergebot avatar Feb 26 '24 16:02 pytorchmergebot

@pytorchbot merge

mikaylagawarecki avatar Feb 28 '24 17:02 mikaylagawarecki

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging Check the merge workflow status here

pytorchmergebot avatar Feb 28 '24 17:02 pytorchmergebot