pytorch icon indicating copy to clipboard operation
pytorch copied to clipboard

[dynamo][guards-c++-refactor] Introduce LeafGuard, GuardManager and GuardAccessor classes

Open anijain2305 opened this issue 2 years ago • 1 comments

Stack from ghstack (oldest at bottom):

  • #120123
  • #120119
  • #120098
  • #120096
  • #120093
  • #120091
  • #120089
  • #120068
  • #120067
  • #120065
  • #120064
  • #120062
  • #120061
  • #120060
  • #119828
  • #119833
  • #119827
  • -> #119822

The full blown implementation is in this stack - https://github.com/pytorch/pytorch/pull/110590 which is passing all the test cases on CI. That stack is hard to review. So, breaking apart.

cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @chenyang78 @aakhundov @kadeng

anijain2305 avatar Feb 13 '24 19:02 anijain2305

:link: Helpful Links

:test_tube: See artifacts and rendered test results at hud.pytorch.org/pr/119822

Note: Links to docs will display an error until the docs builds have been completed.

:white_check_mark: You can merge normally! (1 Unrelated Failure)

As of commit b568644c1168fe0be1c1598676992aa1314685c8 with merge base 62e5840b36b6790a5008faa76a920c6d154897b9 (image):

FLAKY - The following job failed but was likely due to flakiness present on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

pytorch-bot[bot] avatar Feb 13 '24 19:02 pytorch-bot[bot]

@jansel This is ready for another review.

anijain2305 avatar Feb 18 '24 06:02 anijain2305

@jansel Ready for re-review.

anijain2305 avatar Feb 20 '24 01:02 anijain2305

@pytorchbot label "topic: not user facing"

anijain2305 avatar Feb 20 '24 03:02 anijain2305