pytorch icon indicating copy to clipboard operation
pytorch copied to clipboard

[DCP] Adds utility for converting torch save to dcp

Open LucasLLC opened this issue 1 year ago • 6 comments

Stack from ghstack (oldest at bottom):

  • #120128
  • #120127
  • #119816
  • -> #119815
  • #119814
  • #119813

as title

Differential Revision: D53718040

cc @mrshenli @pritamdamania87 @zhaojuanmao @satgera @rohan-varma @gqchen @aazzolini @osalpekar @jiayisuse @H-Huang @kwen2501 @awgu @penguinwu @fegin @XilunWu @wanchaol @fduwjj @wz337 @tianyu-l @wconstab @yf225

LucasLLC avatar Feb 13 '24 19:02 LucasLLC

:link: Helpful Links

:test_tube: See artifacts and rendered test results at hud.pytorch.org/pr/119815

Note: Links to docs will display an error until the docs builds have been completed.

:white_check_mark: You can merge normally! (3 Unrelated Failures)

As of commit 82f2ff43c77dde8c3f66b1dd92c48c8be9593fa7 with merge base c9459e7f555e645badc4803ecde1a3bde1f6b859 (image):

FLAKY - The following job failed but was likely due to flakiness present on trunk:

UNSTABLE - The following jobs failed but were likely due to flakiness present on trunk and has been marked as unstable:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

pytorch-bot[bot] avatar Feb 13 '24 19:02 pytorch-bot[bot]

This pull request was exported from Phabricator. Differential Revision: D53718040

facebook-github-bot avatar Feb 13 '24 19:02 facebook-github-bot

This pull request was exported from Phabricator. Differential Revision: D53718040

facebook-github-bot avatar Feb 14 '24 18:02 facebook-github-bot

This pull request was exported from Phabricator. Differential Revision: D53718040

facebook-github-bot avatar Feb 14 '24 22:02 facebook-github-bot

This pull request was exported from Phabricator. Differential Revision: D53718040

facebook-github-bot avatar Feb 16 '24 23:02 facebook-github-bot

This pull request was exported from Phabricator. Differential Revision: D53718040

facebook-github-bot avatar Feb 17 '24 00:02 facebook-github-bot

This pull request was exported from Phabricator. Differential Revision: D53718040

facebook-github-bot avatar Feb 20 '24 16:02 facebook-github-bot

@pytorchbot merge

LucasLLC avatar Feb 21 '24 22:02 LucasLLC

Merge failed

Reason: This PR needs a release notes: label If your changes are user facing and intended to be a part of release notes, please use a label starting with release notes:.

If not, please add the topic: not user facing label.

To add a label, you can comment to pytorchbot, for example @pytorchbot label "topic: not user facing"

For more information, see https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

Details for Dev Infra team Raised by workflow job

pytorchmergebot avatar Feb 21 '24 22:02 pytorchmergebot

@pytorchbot merge

LucasLLC avatar Feb 22 '24 16:02 LucasLLC

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging Check the merge workflow status here

pytorchmergebot avatar Feb 22 '24 16:02 pytorchmergebot

Merge failed

Reason: Command git -C /home/runner/work/pytorch/pytorch cherry-pick -x faacbd37df359b57806dc61874e0deeced2e69b5 returned non-zero exit code 1

Auto-merging docs/source/distributed.checkpoint.rst
CONFLICT (content): Merge conflict in docs/source/distributed.checkpoint.rst
CONFLICT (modify/delete): test/distributed/checkpoint/test_format_utils.py deleted in HEAD and modified in faacbd37df3 ([DCP] Adds utility for converting torch save to dcp).  Version faacbd37df3 ([DCP] Adds utility for converting torch save to dcp) of test/distributed/checkpoint/test_format_utils.py left in tree.
CONFLICT (modify/delete): torch/distributed/checkpoint/format_utils.py deleted in HEAD and modified in faacbd37df3 ([DCP] Adds utility for converting torch save to dcp).  Version faacbd37df3 ([DCP] Adds utility for converting torch save to dcp) of torch/distributed/checkpoint/format_utils.py left in tree.
error: could not apply faacbd37df3... [DCP] Adds utility for converting torch save to dcp
hint: After resolving the conflicts, mark them with
hint: "git add/rm <pathspec>", then run
hint: "git cherry-pick --continue".
hint: You can instead skip this commit with "git cherry-pick --skip".
hint: To abort and get back to the state before "git cherry-pick",
hint: run "git cherry-pick --abort".
Details for Dev Infra team Raised by workflow job

pytorchmergebot avatar Feb 22 '24 16:02 pytorchmergebot

@pytorchbot merge

LucasLLC avatar Feb 22 '24 17:02 LucasLLC

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging Check the merge workflow status here

pytorchmergebot avatar Feb 22 '24 17:02 pytorchmergebot