pytorch.github.io icon indicating copy to clipboard operation
pytorch.github.io copied to clipboard

Add torch compile row to pytorch install table

Open suryasidd opened this issue 1 year ago • 8 comments

Proposal to enhance torch.compile onboarding by adding installation instructions on the PyTorch main page:

Currently, there is no visibility of torch compile backends on the Pytorch main page. Developers looking to use torch.compile with a specific backend must navigate through multiple steps: they first consult the torch.compile documentation, then visit individual backend documentation pages to understand installation requirements. This process adds unnecessary friction, especially for those just getting started with torch.compile

We propose adding a dedicated torch.compile row to the Install Table on the PyTorch main page. Given the high traffic on this page, this change would streamline this process for developers. By clicking on the desired backend, developers will be provided with simple installation and usage command making it easier for them to get started.

Sample webpage: https://suryasidd.github.io/pytorch.github.io/

suryasidd avatar Oct 09 '24 01:10 suryasidd

CLA Not Signed

Deploy Preview for pytorch-dot-org-preview processing.

Name Link
Latest commit c8889898fafe51455a0c83163a431c76bdd3cd8a
Latest deploy log https://app.netlify.com/sites/pytorch-dot-org-preview/deploys/6705de5ed9f7010008e37724

netlify[bot] avatar Oct 09 '24 01:10 netlify[bot]

Hi, I'm not sure if we need to make the changes to the script in https://github.com/pytorch/test-infra/blob/main/.github/workflows/generate_binary_build_matrix.yml instead of modifying the js files directly. Please advise

suryasidd avatar Oct 09 '24 01:10 suryasidd

cc @svekars

agunapal avatar Nov 04 '24 18:11 agunapal

@suryasidd please sign the CLA

kit1980 avatar Nov 04 '24 18:11 kit1980

Hi @suryasidd the getting started page is already quite complex. We probably don't want to make it even more complex by adding torch.compile section to it. Maybe this can be designed as separate page ?

atalman avatar Nov 04 '24 19:11 atalman

@suryasidd I agree with @atalman . Also, torch.compile is one of the technologies. If we add this, then it would open up possibilities for other technologies as well, making the page even more complex.

agunapal avatar Nov 04 '24 21:11 agunapal

I understand. Would it be possible to add a section for torch.compile in the main page and then link it to the torch.compiler docs page ?

suryasidd avatar Nov 06 '24 03:11 suryasidd